Add string fallback for number

weswigham · weswigham · commit e78530cf9b11 · 2018-04-17T15:51:15.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -4176,7 +4176,7 @@ namespace ts {
                         const exprType = checkExpression((name as ComputedPropertyName).expression);
                         let indexerType: Type;
                         if (isTypeAssignableToKind(exprType, TypeFlags.NumberLike)) {
-                            indexerType = getIndexTypeOfType(parentType, IndexKind.Number);
+                            indexerType = getIndexTypeOfType(parentType, IndexKind.Number) || getIndexTypeOfType(parentType, IndexKind.String);
                         }
                         else if (isTypeAssignableToKind(exprType, TypeFlags.StringLike)) {
                             indexerType = getIndexTypeOfType(parentType, IndexKind.String);

Original file line number	Diff line number	Diff line change
`@@ -4176,7 +4176,7 @@ namespace ts {`
`4176`	`4176`	`const exprType = checkExpression((name as ComputedPropertyName).expression);`
`4177`	`4177`	`let indexerType: Type;`
`4178`	`4178`	`if (isTypeAssignableToKind(exprType, TypeFlags.NumberLike)) {`
`4179`		`- indexerType = getIndexTypeOfType(parentType, IndexKind.Number);`
	`4179`	`+ indexerType = getIndexTypeOfType(parentType, IndexKind.Number) \|\| getIndexTypeOfType(parentType, IndexKind.String);`
`4180`	`4180`	`}`
`4181`	`4181`	`else if (isTypeAssignableToKind(exprType, TypeFlags.StringLike)) {`
`4182`	`4182`	`indexerType = getIndexTypeOfType(parentType, IndexKind.String);`