Initial change to allow noCheck on commandLine (including build) and tests

Author: sheetalkamat

src/compiler/commandLineParser.ts

@@ -502,6 +502,26 @@ export const commonOptionsWithBuild: CommandLineOption[] = [
         description: Diagnostics.Include_sourcemap_files_inside_the_emitted_JavaScript,
         defaultValueDescription: false,
     },
+    {
+        name: "noCheck",
+        type: "boolean",
+        showInSimplifiedHelpView: false,
+        category: Diagnostics.Compiler_Diagnostics,
+        description: Diagnostics.Disable_full_type_checking_only_critical_parse_and_emit_errors_will_be_reported,
+        transpileOptionValue: true,
+        defaultValueDescription: false,
+        affectsSemanticDiagnostics: true,
+        affectsBuildInfo: true,
+    },
+    {
+        name: "noEmit",
+        type: "boolean",
+        showInSimplifiedHelpView: true,
+        category: Diagnostics.Emit,
+        description: Diagnostics.Disable_emitting_files_from_a_compilation,
+        transpileOptionValue: undefined,
+        defaultValueDescription: false,
+    },
     {
         name: "assumeChangesOnlyAffectDirectDependencies",
         type: "boolean",
@@ -772,29 +792,6 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [
         defaultValueDescription: false,
         description: Diagnostics.Disable_emitting_comments,
     },
-    {
-        name: "noCheck",
-        type: "boolean",
-        showInSimplifiedHelpView: false,
-        category: Diagnostics.Compiler_Diagnostics,
-        description: Diagnostics.Disable_full_type_checking_only_critical_parse_and_emit_errors_will_be_reported,
-        transpileOptionValue: true,
-        defaultValueDescription: false,
-        affectsSemanticDiagnostics: true,
-        affectsBuildInfo: true,
-        extraValidation() {
-            return [Diagnostics.Unknown_compiler_option_0, "noCheck"];
-        },
-    },
-    {
-        name: "noEmit",
-        type: "boolean",
-        showInSimplifiedHelpView: true,
-        category: Diagnostics.Emit,
-        description: Diagnostics.Disable_emitting_files_from_a_compilation,
-        transpileOptionValue: undefined,
-        defaultValueDescription: false,
-    },
     {
         name: "importHelpers",
         type: "boolean",

src/testRunner/tests.ts

@@ -122,6 +122,7 @@ export * from "./unittests/tsc/incremental.js";
 export * from "./unittests/tsc/libraryResolution.js";
 export * from "./unittests/tsc/listFilesOnly.js";
 export * from "./unittests/tsc/moduleResolution.js";
+export * from "./unittests/tsc/noCheck.js";
 export * from "./unittests/tsc/noEmit.js";
 export * from "./unittests/tsc/noEmitOnError.js";
 export * from "./unittests/tsc/projectReferences.js";

src/testRunner/unittests/helpers/noCheck.ts

@@ -0,0 +1,81 @@
+import { jsonToReadableText } from "../helpers.js";
+import {
+    noChangeRun,
+    TestTscEdit,
+    verifyTsc,
+} from "./tsc.js";
+import { loadProjectFromFiles } from "./vfs.js";
+
+export function forEachTscScenarioWithNoCheck(buildType: "-b" | "-p") {
+    const commandLineArgs = buildType === "-b" ?
+        ["-b", "/src/tsconfig.json", "-v"] :
+        ["-p", "/src/tsconfig.json"];
+
+    function forEachNoCheckScenarioWorker(
+        subScenario: string,
+        aText: string,
+    ) {
+        const checkNoChangeRun: TestTscEdit = {
+            ...noChangeRun,
+            caption: "No Change run with checking",
+            commandLineArgs,
+        };
+        const noCheckFixError: TestTscEdit = {
+            caption: "Fix `a` error with noCheck",
+            edit: fs => fs.writeFileSync("/src/a.ts", `export const a = "hello";`),
+        };
+        const noCheckError: TestTscEdit = {
+            caption: "Introduce error with noCheck",
+            edit: fs => fs.writeFileSync("/src/a.ts", aText),
+        };
+
+        [undefined, true].forEach(incremental => {
+            [{}, { module: "amd", outFile: "../outFile.js" }].forEach(options => {
+                verifyTsc({
+                    scenario: "noCheck",
+                    subScenario: `${options.outFile ? "outFile" : "multiFile"}/${subScenario}${incremental ? " with incremental" : ""}`,
+                    fs: () =>
+                        loadProjectFromFiles({
+                            "/src/a.ts": aText,
+                            "/src/b.ts": `export const b = 10;`,
+                            "/src/tsconfig.json": jsonToReadableText({
+                                compilerOptions: {
+                                    declaration: true,
+                                    incremental,
+                                    ...options,
+                                },
+                            }),
+                        }),
+                    commandLineArgs: [...commandLineArgs, "--noCheck"],
+                    edits: [
+                        noChangeRun, // Should be no op
+                        noCheckFixError, // Fix error with noCheck
+                        noChangeRun, // Should be no op
+                        checkNoChangeRun, // Check errors - should not report any errors - update buildInfo
+                        checkNoChangeRun, // Should be no op
+                        noChangeRun, // Should be no op
+                        noCheckError,
+                        noChangeRun, // Should be no op
+                        checkNoChangeRun, // Should check errors and update buildInfo
+                        noCheckFixError, // Fix error with noCheck
+                        checkNoChangeRun, // Should check errors and update buildInfo
+                        {
+                            caption: "Add file with error",
+                            edit: fs => fs.writeFileSync("/src/c.ts", `export const c: number = "hello";`),
+                            commandLineArgs,
+                        },
+                        noCheckError,
+                        noCheckFixError,
+                        checkNoChangeRun,
+                        noChangeRun, // Should be no op
+                        checkNoChangeRun, // Should be no op
+                    ],
+                    baselinePrograms: true,
+                });
+            });
+        });
+    }
+    forEachNoCheckScenarioWorker("syntax errors", `export const a = "hello`);
+    forEachNoCheckScenarioWorker("semantic errors", `export const a: number = "hello";`);
+    forEachNoCheckScenarioWorker("dts errors", `export const a = class { private p = 10; };`);
+}

src/testRunner/unittests/tsbuild/noCheck.ts

@@ -1,86 +1,5 @@
-import {
-    CommandLineOption,
-    optionDeclarations,
-} from "../../_namespaces/ts.js";
-import { jsonToReadableText } from "../helpers.js";
-import {
-    noChangeRun,
-    verifyTsc,
-} from "../helpers/tsc.js";
-import { loadProjectFromFiles } from "../helpers/vfs.js";
+import { forEachTscScenarioWithNoCheck } from "../helpers/noCheck.js";
 
-function verifyNoCheckFlag(variant: string) {
-    function verifyNoCheckWorker(subScenario: string, declAText: string, commandLineArgs: readonly string[]) {
-        verifyTsc({
-            scenario: variant,
-            subScenario,
-            fs: () =>
-                loadProjectFromFiles({
-                    "/src/a.ts": getATsContent(declAText),
-                    "/src/tsconfig.json": jsonToReadableText({
-                        compilerOptions: { noCheck: true, emitDeclarationOnly: true, declaration: true },
-                    }),
-                }),
-            commandLineArgs,
-            edits: [
-                noChangeRun,
-                {
-                    caption: "Fix `a` error",
-                    edit: fs => fs.writeFileSync("/src/a.ts", getATsContent(`const a = "hello"`)),
-                },
-                noChangeRun,
-                {
-                    caption: "Disable noCheck",
-                    edit: fs =>
-                        fs.writeFileSync(
-                            "/src/tsconfig.json",
-                            jsonToReadableText({
-                                compilerOptions: { emitDeclarationOnly: true, declaration: true },
-                            }),
-                        ),
-                },
-                noChangeRun,
-            ],
-            baselinePrograms: true,
-        });
-
-        function getATsContent(declAText: string) {
-            return `const err: number = "error";
-${declAText}`;
-        }
-    }
-
-    function verifyNoCheck(subScenario: string, aTsContent: string) {
-        verifyNoCheckWorker(subScenario, aTsContent, ["--b", "/src/tsconfig.json", "-v"]);
-        verifyNoCheckWorker(`${subScenario} with incremental`, aTsContent, ["--b", "/src/tsconfig.json", "-v", "--incremental"]);
-    }
-
-    verifyNoCheck("syntax errors", `const a = "hello`);
-    verifyNoCheck("semantic errors", `const a: number = "hello"`);
-}
-
-describe("unittests:: tsbuild:: noCheck", () => {
-    // Enable the `noCheck` option on the CLI for testing purposes, to ensure it works with incremental/build
-    let validate: CommandLineOption["extraValidation"];
-    before(() => {
-        for (const opt of optionDeclarations) {
-            if (opt.name === "noCheck") {
-                validate = opt.extraValidation;
-                opt.extraValidation = () => undefined;
-            }
-        }
-    });
-    after(() => {
-        for (const opt of optionDeclarations) {
-            if (opt.name === "noCheck") {
-                opt.extraValidation = validate;
-            }
-        }
-    });
-
-    verifyNoCheckFlag("noCheck");
-});
-
-describe("unittests:: tsbuild:: noCheck:: errors", () => {
-    verifyNoCheckFlag("noCheck-errors");
+describe("unittests:: tsbuild:: noCheck::", () => {
+    forEachTscScenarioWithNoCheck("-b");
 });

src/testRunner/unittests/tsc/noCheck.ts

@@ -0,0 +1,5 @@
+import { forEachTscScenarioWithNoCheck } from "../helpers/noCheck.js";
+
+describe("unittests:: tsc:: noCheck::", () => {
+    forEachTscScenarioWithNoCheck("-p");
+});

tests/baselines/reference/config/initTSConfig/Default initialized TSConfig/tsconfig.json

@@ -54,10 +54,10 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
+    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
     // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
     // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with --help/tsconfig.json

@@ -54,10 +54,10 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
+    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
     // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
     // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with --watch/tsconfig.json

@@ -54,10 +54,10 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
+    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
     // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
     // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with advanced options/tsconfig.json

@@ -54,10 +54,10 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
+    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
     // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
     // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with boolean value compiler options/tsconfig.json

@@ -54,10 +54,10 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
+    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
     // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
     // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with enum value compiler options/tsconfig.json

@@ -54,10 +54,10 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
+    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
     // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
     // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */

tests/baselines/reference/config/initTSConfig/Initialized TSConfig with files options/tsconfig.json

@@ -54,10 +54,10 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
+    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
     // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
     // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */