Try running esbuild on tsc output

Author: jakebailey

Gulpfile.js

@@ -109,13 +109,15 @@ async function esbuild(entrypoint, outfile) {
     ]);
 }
 
-const preBundle = parallel(generateLibs, series(buildScripts, generateDiagnostics, localize));
+const buildSrc = () => buildProject("src");
+
+const preBundle = parallel(generateLibs, series(buildScripts, generateDiagnostics, localize, buildSrc));
 
-const bundleTsc = () => esbuild("./src/tsc/tsc.ts", "./built/local/tsc.js");
-const bundleTypescript = () => esbuild("./src/typescript/typescript.ts", "./built/local/typescript.js");
-const bundleServer = () => esbuild("./src/tsserver/server.ts", "./built/local/tsserver.js");
-const bundleServerLibrary = () => esbuild("./src/tsserverlibrary/tsserverlibrary.ts", "./built/local/tsserverlibrary.js");
-const bundleTests = () => esbuild("./src/testRunner/_namespaces/Harness.ts", testRunner);
+const bundleTsc = () => esbuild("./built/local/tsc/tsc.js", "./built/local/tsc.js");
+const bundleTypescript = () => esbuild("./built/local/typescript/typescript.js", "./built/local/typescript.js");
+const bundleServer = () => esbuild("./built/local/tsserver/server.js", "./built/local/tsserver.js");
+const bundleServerLibrary = () => esbuild("./built/local/tsserverlibrary/tsserverlibrary.js", "./built/local/tsserverlibrary.js");
+const bundleTests = () => esbuild("./built/local/testRunner/_namespaces/Harness.js", testRunner);
 
 
 const bundleAll = series([
@@ -128,8 +130,7 @@ const bundleAll = series([
 task("bundle", series(preBundle, bundleAll));
 
 
-const buildSrc = () => buildProject("src");
-task("buildSrc", series(preBundle, bundleAll, buildSrc));
+task("buildSrc", series(preBundle));
 
 const apiExtractor = async () => {
     async function runApiExtractor(configPath) {

src/compiler/sys.ts

@@ -1574,7 +1574,10 @@ export let sys: System = (() => {
             debugMode: !!process.env.NODE_INSPECTOR_IPC || !!process.env.VSCODE_INSPECTOR_OPTIONS || some(process.execArgv as string[], arg => /^--(inspect|debug)(-brk)?(=\d+)?$/i.test(arg)),
             tryEnableSourceMapsForHost() {
                 try {
-                    require("source-map-support").install();
+                    // Trick esbuild into not eagerly resolving a path to a JS file.
+                    // See: https://github.com/evanw/esbuild/issues/1958
+                    const moduleName = "source-map-support" as const;
+                    (require(moduleName) as typeof import("source-map-support")).install();
                 }
                 catch {
                     // Could not enable source maps.

src/server/scriptVersionCache.ts

@@ -255,16 +255,16 @@ class TextChange {
 
 /** @internal */
 export class ScriptVersionCache {
+    private static readonly changeNumberThreshold = 8;
+    private static readonly changeLengthThreshold = 256;
+    private static readonly maxVersions = 8;
+
     private changes: TextChange[] = [];
     private readonly versions: LineIndexSnapshot[] = new Array<LineIndexSnapshot>(ScriptVersionCache.maxVersions);
     private minVersion = 0; // no versions earlier than min version will maintain change history
 
     private currentVersion = 0;
 
-    private static readonly changeNumberThreshold = 8;
-    private static readonly changeLengthThreshold = 256;
-    private static readonly maxVersions = 8;
-
     private versionToIndex(version: number) {
         if (version < this.minVersion || version > this.currentVersion) {
             return undefined;

src/services/services.ts

@@ -484,9 +484,9 @@ class IdentifierObject extends TokenOrIdentifierObject implements Identifier {
 }
 IdentifierObject.prototype.kind = SyntaxKind.Identifier;
 class PrivateIdentifierObject extends TokenOrIdentifierObject implements PrivateIdentifier {
-    public kind!: SyntaxKind.PrivateIdentifier;
+    public kind: SyntaxKind.PrivateIdentifier = SyntaxKind.PrivateIdentifier;
     public escapedText!: __String;
-    public symbol!: Symbol;
+    // public symbol!: Symbol;
     _primaryExpressionBrand: any;
     _memberExpressionBrand: any;
     _leftHandSideExpressionBrand: any;

src/tsconfig-base.json

@@ -10,7 +10,7 @@
         "sourceMap": true,
         "composite": true,
         "noEmitOnError": true,
-        "emitDeclarationOnly": true,
+        // "emitDeclarationOnly": true,
 
         "strictNullChecks": true,
         "noImplicitAny": true,