Merge pull request #11978 from Microsoft/errorReportingInJsFile

 Report all the js file errors and skip only the nodes that are not allowed in JS file

Author: sheetalkamat

src/compiler/program.ts

@@ -514,6 +514,10 @@ namespace ts {
 
     export function createDiagnosticForNode(node: Node, message: DiagnosticMessage, arg0?: string | number, arg1?: string | number, arg2?: string | number): Diagnostic {
         const sourceFile = getSourceFileOfNode(node);
+        return createDiagnosticForNodeInSourceFile(sourceFile, node, message, arg0, arg1, arg2);
+    }
+
+    export function createDiagnosticForNodeInSourceFile(sourceFile: SourceFile, node: Node, message: DiagnosticMessage, arg0?: string | number, arg1?: string | number, arg2?: string | number): Diagnostic {
         const span = getErrorSpanForNode(sourceFile, node);
         return createFileDiagnostic(sourceFile, span.start, span.length, message, arg0, arg1, arg2);
     }

src/compiler/utilities.ts

@@ -0,0 +1,13 @@
+tests/cases/compiler/a.js(4,12): error TS8010: 'types' can only be used in a .ts file.
+
+
+==== tests/cases/compiler/a.js (1 errors) ====
+    
+    @SomeDecorator
+    class SomeClass {
+        foo(x: number) {
+               ~~~~~~
+!!! error TS8010: 'types' can only be used in a .ts file.
+    
+        }
+    }

tests/baselines/reference/decoratorInJsFile.errors.txt

@@ -0,0 +1,16 @@
+tests/cases/compiler/a.js(3,7): error TS1219: Experimental support for decorators is a feature that is subject to change in a future release. Set the 'experimentalDecorators' option to remove this warning.
+tests/cases/compiler/a.js(4,12): error TS8010: 'types' can only be used in a .ts file.
+
+
+==== tests/cases/compiler/a.js (2 errors) ====
+    
+    @SomeDecorator
+    class SomeClass {
+          ~~~~~~~~~
+!!! error TS1219: Experimental support for decorators is a feature that is subject to change in a future release. Set the 'experimentalDecorators' option to remove this warning.
+        foo(x: number) {
+               ~~~~~~
+!!! error TS8010: 'types' can only be used in a .ts file.
+    
+        }
+    }

tests/baselines/reference/decoratorInJsFile1.errors.txt

@@ -0,0 +1,16 @@
+error TS5055: Cannot write file 'tests/cases/compiler/a.js' because it would overwrite input file.
+  Adding a tsconfig.json file will help organize projects that contain both TypeScript and JavaScript files. Learn more at https://aka.ms/tsconfig
+tests/cases/compiler/a.js(1,1): error TS8009: 'abstract' can only be used in a .ts file.
+tests/cases/compiler/a.js(2,5): error TS8009: 'abstract' can only be used in a .ts file.
+
+
+!!! error TS5055: Cannot write file 'tests/cases/compiler/a.js' because it would overwrite input file.
+!!! error TS5055:   Adding a tsconfig.json file will help organize projects that contain both TypeScript and JavaScript files. Learn more at https://aka.ms/tsconfig
+==== tests/cases/compiler/a.js (2 errors) ====
+    abstract class c {
+    ~~~~~~~~
+!!! error TS8009: 'abstract' can only be used in a .ts file.
+        abstract x;
+        ~~~~~~~~
+!!! error TS8009: 'abstract' can only be used in a .ts file.
+    }

tests/baselines/reference/jsFileCompilationAbstractModifier.errors.txt

@@ -0,0 +1,4 @@
+=== tests/cases/compiler/a.js ===
+const c = 10;
+>c : Symbol(c, Decl(a.js, 0, 5))
+

tests/baselines/reference/jsFileCompilationConstModifier.symbols

@@ -0,0 +1,5 @@
+=== tests/cases/compiler/a.js ===
+const c = 10;
+>c : 10
+>10 : 10
+

tests/baselines/reference/jsFileCompilationConstModifier.types

@@ -0,0 +1,12 @@
+// @experimentaldecorators: true
+// @emitdecoratormetadata: true
+// @allowjs: true
+// @noEmit: true
+
+// @filename: a.js
+@SomeDecorator
+class SomeClass {
+    foo(x: number) {
+
+    }
+}

tests/cases/compiler/decoratorInJsFile.ts

@@ -0,0 +1,10 @@
+// @allowjs: true
+// @noEmit: true
+
+// @filename: a.js
+@SomeDecorator
+class SomeClass {
+    foo(x: number) {
+
+    }
+}

tests/cases/compiler/decoratorInJsFile1.ts

@@ -0,0 +1,5 @@
+// @allowJs: true
+// @filename: a.js
+abstract class c {
+    abstract x;
+}

tests/cases/compiler/jsFileCompilationAbstractModifier.ts

@@ -0,0 +1,4 @@
+// @allowJs: true
+// @filename: a.js
+// @noEmit: true
+const c = 10;

tests/cases/compiler/jsFileCompilationConstModifier.ts

@@ -15,6 +15,13 @@ verify.getSyntacticDiagnostics(`[
     "category": "error",
     "code": 8010
   },
+  {
+    "message": "\'types\' can only be used in a .ts file.",
+    "start": 52,
+    "length": 6,
+    "category": "error",
+    "code": 8010
+  },
   {
     "message": "Variable declaration expected.",
     "start": 67,