Do not add alias back if it was never removed (such as in the case of keyword properties)

Author: dragomirtitian

src/compiler/transformers/declarations.ts

@@ -888,7 +888,9 @@ export function transformDeclarations(context: TransformationContext) {
                     return elem;
                 }
                 const usedAlias = aliases!.get(getOriginalNode(elem));
-                if (usedAlias) {
+                // If alias is used and property name was removed by filterBindingPatternInitializersAndRenamings
+                // The alias can be preserved if it is a non contextual keyword.
+                if (usedAlias && !elem.propertyName) {
                     return factory.updateBindingElement(
                         elem,
                         elem.dotDotDotToken,

tests/baselines/reference/declarationEmitBindingPatternsUnused.errors.txt

@@ -1,9 +1,9 @@
-declarationEmitBindingPatternsUnused.ts(81,35): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
-declarationEmitBindingPatternsUnused.ts(85,41): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
-declarationEmitBindingPatternsUnused.ts(91,11): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
-declarationEmitBindingPatternsUnused.ts(92,15): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
-declarationEmitBindingPatternsUnused.ts(93,16): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
-declarationEmitBindingPatternsUnused.ts(94,12): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
+declarationEmitBindingPatternsUnused.ts(85,35): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
+declarationEmitBindingPatternsUnused.ts(89,41): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
+declarationEmitBindingPatternsUnused.ts(95,11): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
+declarationEmitBindingPatternsUnused.ts(96,15): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
+declarationEmitBindingPatternsUnused.ts(97,16): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
+declarationEmitBindingPatternsUnused.ts(98,12): error TS2842: 'alias' is an unused renaming of 'name'. Did you intend to use it as a type annotation?
 
 
 ==== declarationEmitBindingPatternsUnused.ts (6 errors) ====
@@ -26,6 +26,10 @@ declarationEmitBindingPatternsUnused.ts(94,12): error TS2842: 'alias' is an unus
         return alias;
     }
 
+    function referencedInSignartureKeyword({ function: alias }: { function: string }): typeof alias {
+        return null!;
+    }
+    
     function referencedInInferredType({ name: alias }: Named) {
         type Named2 = { name: typeof alias }
         return null! as Named2

tests/baselines/reference/declarationEmitBindingPatternsUnused.js

@@ -20,6 +20,10 @@ function referencedInSignarture({ name: alias }: Named): typeof alias {
     return alias;
 }
 
+function referencedInSignartureKeyword({ function: alias }: { function: string }): typeof alias {
+    return null!;
+}
+
 function referencedInInferredType({ name: alias }: Named) {
     type Named2 = { name: typeof alias }
     return null! as Named2
@@ -122,6 +126,9 @@ function referencedInCode({ name: alias }) {
 function referencedInSignarture({ name: alias }) {
     return alias;
 }
+function referencedInSignartureKeyword({ function: alias }) {
+    return null;
+}
 function referencedInInferredType({ name: alias }) {
     return null;
 }
@@ -191,6 +198,9 @@ declare function notReferencedNestedAlias({ p: { name } }: {
 declare function notReferencedArrayAlias([a, b, { name }]: Named[]): void;
 declare function referencedInCode({ name }: Named): string;
 declare function referencedInSignarture({ name: alias }: Named): typeof alias;
+declare function referencedInSignartureKeyword({ function: alias }: {
+    function: string;
+}): typeof alias;
 declare function referencedInInferredType({ name: alias }: Named): {
     name: typeof alias;
 };