Skip to content

Commit c35e374

Browse files
committed
runtests-parallel skips empty buckets
Previously, it would enter them as buckets with no tests, which would make our test runners run *every* test. This was very obvious on machines with lots of cores.
1 parent 6be7d9c commit c35e374

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/harness/runner.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ if (taskConfigsFolder) {
193193
for (let i = 0; i < workerCount; i++) {
194194
const startPos = i * chunkSize;
195195
const len = Math.min(chunkSize, files.length - startPos);
196-
if (len !== 0) {
196+
if (len > 0) {
197197
workerConfigs[i].tasks.push({
198198
runner: runner.kind(),
199199
files: files.slice(startPos, startPos + len)
@@ -214,5 +214,5 @@ else {
214214
}
215215
if (!runUnitTests) {
216216
// patch `describe` to skip unit tests
217-
describe = <any>describe.skip;
218-
}
217+
describe = <any>(function () { });
218+
}

0 commit comments

Comments
 (0)