Skip to content

Commit bc2983d

Browse files
ajafffmhegazy
authored andcommitted
API: fix types to undefined union (#20909)
1 parent e35585b commit bc2983d

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

src/compiler/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2540,7 +2540,7 @@ namespace ts {
25402540
export interface ParseConfigHost {
25412541
useCaseSensitiveFileNames: boolean;
25422542

2543-
readDirectory(rootDir: string, extensions: ReadonlyArray<string>, excludes: ReadonlyArray<string>, includes: ReadonlyArray<string>, depth: number): string[];
2543+
readDirectory(rootDir: string, extensions: ReadonlyArray<string>, excludes: ReadonlyArray<string> | undefined, includes: ReadonlyArray<string>, depth?: number): string[];
25442544

25452545
/**
25462546
* Gets a value indicating whether the specified path exists and is a file.
@@ -4380,11 +4380,11 @@ namespace ts {
43804380
* If resolveModuleNames is implemented then implementation for members from ModuleResolutionHost can be just
43814381
* 'throw new Error("NotImplemented")'
43824382
*/
4383-
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[]): ResolvedModule[];
4383+
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[]): (ResolvedModule | undefined)[];
43844384
/**
43854385
* This method is a companion for 'resolveModuleNames' and is used to resolve 'types' references to actual type declaration files
43864386
*/
4387-
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string): ResolvedTypeReferenceDirective[];
4387+
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string): (ResolvedTypeReferenceDirective | undefined)[];
43884388
getEnvironmentVariable?(name: string): string;
43894389
/* @internal */ onReleaseOldSourceFile?(oldSourceFile: SourceFile, oldOptions: CompilerOptions): void;
43904390
/* @internal */ hasInvalidatedResolution?: HasInvalidatedResolution;

tests/baselines/reference/api/tsserverlibrary.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1615,7 +1615,7 @@ declare namespace ts {
16151615
}
16161616
interface ParseConfigHost {
16171617
useCaseSensitiveFileNames: boolean;
1618-
readDirectory(rootDir: string, extensions: ReadonlyArray<string>, excludes: ReadonlyArray<string>, includes: ReadonlyArray<string>, depth: number): string[];
1618+
readDirectory(rootDir: string, extensions: ReadonlyArray<string>, excludes: ReadonlyArray<string> | undefined, includes: ReadonlyArray<string>, depth?: number): string[];
16191619
/**
16201620
* Gets a value indicating whether the specified path exists and is a file.
16211621
* @param path The path to test.
@@ -2468,11 +2468,11 @@ declare namespace ts {
24682468
getCanonicalFileName(fileName: string): string;
24692469
useCaseSensitiveFileNames(): boolean;
24702470
getNewLine(): string;
2471-
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[]): ResolvedModule[];
2471+
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[]): (ResolvedModule | undefined)[];
24722472
/**
24732473
* This method is a companion for 'resolveModuleNames' and is used to resolve 'types' references to actual type declaration files
24742474
*/
2475-
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string): ResolvedTypeReferenceDirective[];
2475+
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string): (ResolvedTypeReferenceDirective | undefined)[];
24762476
getEnvironmentVariable?(name: string): string;
24772477
}
24782478
interface SourceMapRange extends TextRange {

tests/baselines/reference/api/typescript.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1615,7 +1615,7 @@ declare namespace ts {
16151615
}
16161616
interface ParseConfigHost {
16171617
useCaseSensitiveFileNames: boolean;
1618-
readDirectory(rootDir: string, extensions: ReadonlyArray<string>, excludes: ReadonlyArray<string>, includes: ReadonlyArray<string>, depth: number): string[];
1618+
readDirectory(rootDir: string, extensions: ReadonlyArray<string>, excludes: ReadonlyArray<string> | undefined, includes: ReadonlyArray<string>, depth?: number): string[];
16191619
/**
16201620
* Gets a value indicating whether the specified path exists and is a file.
16211621
* @param path The path to test.
@@ -2468,11 +2468,11 @@ declare namespace ts {
24682468
getCanonicalFileName(fileName: string): string;
24692469
useCaseSensitiveFileNames(): boolean;
24702470
getNewLine(): string;
2471-
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[]): ResolvedModule[];
2471+
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[]): (ResolvedModule | undefined)[];
24722472
/**
24732473
* This method is a companion for 'resolveModuleNames' and is used to resolve 'types' references to actual type declaration files
24742474
*/
2475-
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string): ResolvedTypeReferenceDirective[];
2475+
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string): (ResolvedTypeReferenceDirective | undefined)[];
24762476
getEnvironmentVariable?(name: string): string;
24772477
}
24782478
interface SourceMapRange extends TextRange {

0 commit comments

Comments
 (0)