Merge branch 'master' into constructor-functions-as-classes

Author: sandersn

README.md

@@ -1,8 +1,8 @@
 
 # TypeScript
 
-[![Join the chat at https://gitter.im/Microsoft/TypeScript](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/Microsoft/TypeScript?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
-[![Build Status](https://travis-ci.org/microsoft/TypeScript.svg?branch=master)](https://travis-ci.org/Microsoft/TypeScript)
+[![Join the chat at https://gitter.im/microsoft/TypeScript](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/microsoft/TypeScript?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![Build Status](https://travis-ci.org/microsoft/TypeScript.svg?branch=master)](https://travis-ci.org/microsoft/TypeScript)
 [![VSTS Build Status](https://dev.azure.com/typescript/TypeScript/_apis/build/status/Typescript/node10)](https://dev.azure.com/typescript/TypeScript/_build/latest?definitionId=4&view=logs)
 [![npm version](https://badge.fury.io/js/typescript.svg)](https://www.npmjs.com/package/typescript)
 [![Downloads](https://img.shields.io/npm/dm/typescript.svg)](https://www.npmjs.com/package/typescript)
@@ -27,14 +27,14 @@ npm install -g typescript@next
 
 ## Contribute
 
-There are many ways to [contribute](https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md) to TypeScript.
-* [Submit bugs](https://github.com/Microsoft/TypeScript/issues) and help us verify fixes as they are checked in.
-* Review the [source code changes](https://github.com/Microsoft/TypeScript/pulls).
+There are many ways to [contribute](https://github.com/microsoft/TypeScript/blob/master/CONTRIBUTING.md) to TypeScript.
+* [Submit bugs](https://github.com/microsoft/TypeScript/issues) and help us verify fixes as they are checked in.
+* Review the [source code changes](https://github.com/microsoft/TypeScript/pulls).
 * Engage with other TypeScript users and developers on [StackOverflow](https://stackoverflow.com/questions/tagged/typescript).
 * Join the [#typescript](https://twitter.com/search?q=%23TypeScript) discussion on Twitter.
-* [Contribute bug fixes](https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md).
-* Read the language specification ([docx](https://github.com/Microsoft/TypeScript/blob/master/doc/TypeScript%20Language%20Specification.docx?raw=true),
- [pdf](https://github.com/Microsoft/TypeScript/blob/master/doc/TypeScript%20Language%20Specification.pdf?raw=true), [md](https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md)).
+* [Contribute bug fixes](https://github.com/microsoft/TypeScript/blob/master/CONTRIBUTING.md).
+* Read the language specification ([docx](https://github.com/microsoft/TypeScript/blob/master/doc/TypeScript%20Language%20Specification.docx?raw=true),
+ [pdf](https://github.com/microsoft/TypeScript/blob/master/doc/TypeScript%20Language%20Specification.pdf?raw=true), [md](https://github.com/microsoft/TypeScript/blob/master/doc/spec.md)).
 
 This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see
 the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [[email protected]](mailto:[email protected])
@@ -44,7 +44,7 @@ with any additional questions or comments.
 
 *  [Quick tutorial](https://www.typescriptlang.org/docs/tutorial.html)
 *  [Programming handbook](https://www.typescriptlang.org/docs/handbook/basic-types.html)
-*  [Language specification](https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md)
+*  [Language specification](https://github.com/microsoft/TypeScript/blob/master/doc/spec.md)
 *  [Homepage](https://www.typescriptlang.org/)
 
 ## Building
@@ -54,7 +54,7 @@ In order to build the TypeScript compiler, ensure that you have [Git](https://gi
 Clone a copy of the repo:
 
 ```bash
-git clone https://github.com/Microsoft/TypeScript.git
+git clone https://github.com/microsoft/TypeScript.git
 ```
 
 Change to the TypeScript directory:
@@ -73,17 +73,25 @@ npm install
 Use one of the following to build and test:
 
 ```
-gulp local            # Build the compiler into built/local
-gulp clean            # Delete the built compiler
-gulp LKG              # Replace the last known good with the built one.
-                      # Bootstrapping step to be executed when the built compiler reaches a stable state.
-gulp tests            # Build the test infrastructure using the built compiler.
-gulp runtests         # Run tests using the built compiler and test infrastructure.
-                      # You can override the host or specify a test for this command.
-                      # Use --host=<hostName> or --tests=<testPath>.
-gulp baseline-accept  # This replaces the baseline test results with the results obtained from gulp runtests.
-gulp lint             # Runs tslint on the TypeScript source.
-gulp help             # List the above commands.
+gulp local             # Build the compiler into built/local.
+gulp clean             # Delete the built compiler.
+gulp LKG               # Replace the last known good with the built one.
+                       # Bootstrapping step to be executed when the built compiler reaches a stable state.
+gulp tests             # Build the test infrastructure using the built compiler.
+gulp runtests          # Run tests using the built compiler and test infrastructure.
+                       # Some low-value tests are skipped when not on a CI machine - you can use the
+                       # --skipPercent=0 command to override this behavior and run all tests locally.
+                       # You can override the specific suite runner used or specify a test for this command.
+                       # Use --tests=<testPath> for a specific test and/or --runner=<runnerName> for a specific suite.
+                       # Valid runners include conformance, compiler, fourslash, project, user, and docker
+                       # The user and docker runners are extended test suite runners - the user runner
+                       # works on disk in the tests/cases/user directory, while the docker runner works in containers.
+                       # You'll need to have the docker executable in your system path for the docker runner to work.
+gulp runtests-parallel # Like runtests, but split across multiple threads. Uses a number of threads equal to the system
+                       # core count by default. Use --workers=<number> to adjust this.
+gulp baseline-accept   # This replaces the baseline test results with the results obtained from gulp runtests.
+gulp lint              # Runs tslint on the TypeScript source.
+gulp help              # List the above commands.
 ```
 
 
@@ -96,4 +104,4 @@ node built/local/tsc.js hello.ts
 
 ## Roadmap
 
-For details on our planned features and future direction please refer to our [roadmap](https://github.com/Microsoft/TypeScript/wiki/Roadmap).
+For details on our planned features and future direction please refer to our [roadmap](https://github.com/microsoft/TypeScript/wiki/Roadmap).

scripts/open-cherry-pick-pr.ts

@@ -11,6 +11,7 @@ const userName = process.env.GH_USERNAME;
 const reviewers = process.env.REQUESTING_USER ? [process.env.REQUESTING_USER] : ["weswigham", "RyanCavanaugh"];
 const branchName = `pick/${process.env.SOURCE_ISSUE}/${process.env.TARGET_BRANCH}`;
 const remoteUrl = `https://${process.argv[2]}@github.com/${userName}/TypeScript.git`;
+const produceLKG = !!process.env.PRODUCE_LKG;
 
 async function main() {
     if (!process.env.TARGET_BRANCH) {
@@ -52,7 +53,16 @@ ${logText.trim()}`
     runSequence([
         ["git", ["checkout", process.env.TARGET_BRANCH]], // checkout the target branch
         ["git", ["checkout", "-b", branchName]], // create a new branch
-        ["git", ["cherry-pick", squashSha.trim()]], // 
+        ["git", ["cherry-pick", squashSha.trim()]],
+    ]);
+    if (produceLKG) {
+        runSequence([
+            ["gulp", ["LKG"]],
+            ["git", ["add", "lib"]],
+            ["git", ["commit", "-m", `"Update LKG"`]]
+        ]);
+    }
+    runSequence([
         ["git", ["remote", "add", "fork", remoteUrl]], // Add the remote fork
         ["git", ["push", "--set-upstream", "fork", branchName, "-f"]] // push the branch
     ]);
@@ -71,7 +81,7 @@ ${logText.trim()}`
         base: process.env.TARGET_BRANCH,
         body:
     `This cherry-pick was triggerd by a request on https://github.com/Microsoft/TypeScript/pull/${process.env.SOURCE_ISSUE}
-Please review the diff and merge if no changes are unexpected.
+Please review the diff and merge if no changes are unexpected.${produceLKG ? ` An LKG update commit is included seperately from the base change.` : ""}
 You can view the cherry-pick log [here](https://typescript.visualstudio.com/TypeScript/_build/index?buildId=${process.env.BUILD_BUILDID}&_a=summary).
 
 cc ${reviewers.map(r => "@" + r).join(" ")}`,

src/compiler/checker.ts

@@ -9345,10 +9345,10 @@ namespace ts {
                         return globalFunctionType;
                     case "Array":
                     case "array":
-                        return !typeArgs || !typeArgs.length ? anyArrayType : undefined;
+                        return (!typeArgs || !typeArgs.length) && !noImplicitAny ? anyArrayType : undefined;
                     case "Promise":
                     case "promise":
-                        return !typeArgs || !typeArgs.length ? createPromiseType(anyType) : undefined;
+                        return (!typeArgs || !typeArgs.length) && !noImplicitAny ? createPromiseType(anyType) : undefined;
                     case "Object":
                         if (typeArgs && typeArgs.length === 2) {
                             if (isJSDocIndexSignature(node)) {
@@ -9360,7 +9360,7 @@ namespace ts {
                             return anyType;
                         }
                         checkNoTypeArguments(node);
-                        return anyType;
+                        return !noImplicitAny ? anyType : undefined;
                 }
             }
         }

src/compiler/diagnosticMessages.json

@@ -5112,6 +5112,10 @@
         "category": "Message",
         "code": 95087
     },
+    "Enable the '--jsx' flag in your configuration file": {
+        "category": "Message",
+        "code": 95088
+    },
 
     "No value exists in scope for the shorthand property '{0}'. Either declare one or provide an initializer.": {
         "category": "Error",

src/compiler/utilities.ts

@@ -2343,7 +2343,7 @@ namespace ts {
     export function getTypeParameterFromJsDoc(node: TypeParameterDeclaration & { parent: JSDocTemplateTag }): TypeParameterDeclaration | undefined {
         const name = node.name.escapedText;
         const { typeParameters } = (node.parent.parent.parent as SignatureDeclaration | InterfaceDeclaration | ClassDeclaration);
-        return find(typeParameters!, p => p.name.escapedText === name);
+        return typeParameters && find(typeParameters, p => p.name.escapedText === name);
     }
 
     export function hasRestParameter(s: SignatureDeclaration | JSDocSignature): boolean {

src/services/codefixes/fixEnableJsxFlag.ts

@@ -0,0 +1,35 @@
+/* @internal */
+namespace ts.codefix {
+    const fixID = "fixEnableJsxFlag";
+    const errorCodes = [Diagnostics.Cannot_use_JSX_unless_the_jsx_flag_is_provided.code];
+    registerCodeFix({
+        errorCodes,
+        getCodeActions: context => {
+            const { configFile } = context.program.getCompilerOptions();
+            if (configFile === undefined) {
+                return undefined;
+            }
+
+            const changes = textChanges.ChangeTracker.with(context, changeTracker =>
+                doChange(changeTracker, configFile)
+            );
+            return [
+                createCodeFixActionNoFixId(fixID, changes, Diagnostics.Enable_the_jsx_flag_in_your_configuration_file)
+            ];
+        },
+        fixIds: [fixID],
+        getAllCodeActions: context =>
+            codeFixAll(context, errorCodes, changes => {
+                const { configFile } = context.program.getCompilerOptions();
+                if (configFile === undefined) {
+                    return undefined;
+                }
+
+                doChange(changes, configFile);
+            })
+    });
+
+    function doChange(changeTracker: textChanges.ChangeTracker, configFile: TsConfigSourceFile) {
+        setJsonCompilerOptionValue(changeTracker, configFile, "jsx", createStringLiteral("react"));
+    }
+}

src/services/tsconfig.json

@@ -65,6 +65,7 @@
         "codefixes/fixClassSuperMustPrecedeThisAccess.ts",
         "codefixes/fixConstructorForDerivedNeedSuperCall.ts",
         "codefixes/fixEnableExperimentalDecorators.ts",
+        "codefixes/fixEnableJsxFlag.ts",
         "codefixes/fixExtendsInterfaceBecomesImplements.ts",
         "codefixes/fixForgottenThisPropertyAccess.ts",
         "codefixes/fixUnusedIdentifier.ts",

src/testRunner/externalCompileRunner.ts

@@ -52,7 +52,7 @@ abstract class ExternalCompileRunnerBase extends RunnerBase {
                     const submoduleDir = path.join(cwd, directoryName);
                     exec("git", ["reset", "HEAD", "--hard"], { cwd: submoduleDir });
                     exec("git", ["clean", "-f"], { cwd: submoduleDir });
-                    exec("git", ["submodule", "update", "--init", "--remote", "."], { cwd: submoduleDir });
+                    exec("git", ["submodule", "update", "--init", "--remote", "."], { cwd: originalCwd });
 
                     const config = JSON.parse(fs.readFileSync(path.join(cwd, "test.json"), { encoding: "utf8" })) as UserConfig;
                     ts.Debug.assert(!!config.types, "Bad format from test.json: Types field must be present.");

tests/baselines/reference/docker/azure-sdk.log

@@ -2,12 +2,12 @@ Exit Code: 1
 Standard output:
 
 Rush Multi-Project Build Tool 5.X.X - https://rushjs.io
-Node.js version is 12.8.0 (pre-LTS)
+Node.js version is 12.8.1 (pre-LTS)
 Starting "rush rebuild"
 Executing a maximum of ?simultaneous processes...
+XX of XX: [@azure/abort-controller] completed successfully in ? seconds
 XX of XX: [@azure/identity] completed successfully in ? seconds
 XX of XX: [@azure/event-processor-host] completed successfully in ? seconds
-XX of XX: [@azure/abort-controller] completed successfully in ? seconds
 XX of XX: [@azure/core-arm] completed successfully in ? seconds
 XX of XX: [@azure/core-asynciterator-polyfill] completed successfully in ? seconds
 XX of XX: [@azure/core-auth] completed successfully in ? seconds

tests/baselines/reference/jsdocArrayObjectPromiseImplicitAny.symbols

@@ -0,0 +1,69 @@
+=== tests/cases/compiler/jsdocArrayObjectPromiseImplicitAny.js ===
+/** @type {Array} */
+var anyArray = [5];
+>anyArray : Symbol(anyArray, Decl(jsdocArrayObjectPromiseImplicitAny.js, 1, 3))
+
+/** @type {Array<number>} */
+var numberArray = [5];
+>numberArray : Symbol(numberArray, Decl(jsdocArrayObjectPromiseImplicitAny.js, 4, 3))
+
+/**
+ * @param {Array} arr
+ * @return {Array}
+ */
+function returnAnyArray(arr) {
+>returnAnyArray : Symbol(returnAnyArray, Decl(jsdocArrayObjectPromiseImplicitAny.js, 4, 22))
+>arr : Symbol(arr, Decl(jsdocArrayObjectPromiseImplicitAny.js, 10, 24))
+
+  return arr;
+>arr : Symbol(arr, Decl(jsdocArrayObjectPromiseImplicitAny.js, 10, 24))
+}
+
+/** @type {Promise} */
+var anyPromise = Promise.resolve(5);
+>anyPromise : Symbol(anyPromise, Decl(jsdocArrayObjectPromiseImplicitAny.js, 15, 3))
+>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --))
+>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
+>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --))
+
+/** @type {Promise<number>} */
+var numberPromise = Promise.resolve(5);
+>numberPromise : Symbol(numberPromise, Decl(jsdocArrayObjectPromiseImplicitAny.js, 18, 3))
+>Promise.resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --))
+>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
+>resolve : Symbol(PromiseConstructor.resolve, Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --))
+
+/**
+ * @param {Promise} pr
+ * @return {Promise}
+ */
+function returnAnyPromise(pr) {
+>returnAnyPromise : Symbol(returnAnyPromise, Decl(jsdocArrayObjectPromiseImplicitAny.js, 18, 39))
+>pr : Symbol(pr, Decl(jsdocArrayObjectPromiseImplicitAny.js, 24, 26))
+
+  return pr;
+>pr : Symbol(pr, Decl(jsdocArrayObjectPromiseImplicitAny.js, 24, 26))
+}
+
+/** @type {Object} */
+var anyObject = {valueOf: 1}; // not an error since assigning to any.
+>anyObject : Symbol(anyObject, Decl(jsdocArrayObjectPromiseImplicitAny.js, 29, 3))
+>valueOf : Symbol(valueOf, Decl(jsdocArrayObjectPromiseImplicitAny.js, 29, 17))
+
+/** @type {Object<string, number>} */
+var paramedObject = {valueOf: 1};
+>paramedObject : Symbol(paramedObject, Decl(jsdocArrayObjectPromiseImplicitAny.js, 32, 3))
+>valueOf : Symbol(valueOf, Decl(jsdocArrayObjectPromiseImplicitAny.js, 32, 21))
+
+/**
+ * @param {Object} obj
+ * @return {Object}
+ */
+function returnAnyObject(obj) {
+>returnAnyObject : Symbol(returnAnyObject, Decl(jsdocArrayObjectPromiseImplicitAny.js, 32, 33))
+>obj : Symbol(obj, Decl(jsdocArrayObjectPromiseImplicitAny.js, 38, 25))
+
+  return obj;
+>obj : Symbol(obj, Decl(jsdocArrayObjectPromiseImplicitAny.js, 38, 25))
+}
+

tests/baselines/reference/jsdocArrayObjectPromiseImplicitAny.types

@@ -0,0 +1,81 @@
+=== tests/cases/compiler/jsdocArrayObjectPromiseImplicitAny.js ===
+/** @type {Array} */
+var anyArray = [5];
+>anyArray : any[]
+>[5] : number[]
+>5 : 5
+
+/** @type {Array<number>} */
+var numberArray = [5];
+>numberArray : number[]
+>[5] : number[]
+>5 : 5
+
+/**
+ * @param {Array} arr
+ * @return {Array}
+ */
+function returnAnyArray(arr) {
+>returnAnyArray : (arr: any[]) => any[]
+>arr : any[]
+
+  return arr;
+>arr : any[]
+}
+
+/** @type {Promise} */
+var anyPromise = Promise.resolve(5);
+>anyPromise : Promise<any>
+>Promise.resolve(5) : Promise<number>
+>Promise.resolve : { <T>(value: T | PromiseLike<T>): Promise<T>; (): Promise<void>; }
+>Promise : PromiseConstructor
+>resolve : { <T>(value: T | PromiseLike<T>): Promise<T>; (): Promise<void>; }
+>5 : 5
+
+/** @type {Promise<number>} */
+var numberPromise = Promise.resolve(5);
+>numberPromise : Promise<number>
+>Promise.resolve(5) : Promise<number>
+>Promise.resolve : { <T>(value: T | PromiseLike<T>): Promise<T>; (): Promise<void>; }
+>Promise : PromiseConstructor
+>resolve : { <T>(value: T | PromiseLike<T>): Promise<T>; (): Promise<void>; }
+>5 : 5
+
+/**
+ * @param {Promise} pr
+ * @return {Promise}
+ */
+function returnAnyPromise(pr) {
+>returnAnyPromise : (pr: Promise<any>) => Promise<any>
+>pr : Promise<any>
+
+  return pr;
+>pr : Promise<any>
+}
+
+/** @type {Object} */
+var anyObject = {valueOf: 1}; // not an error since assigning to any.
+>anyObject : any
+>{valueOf: 1} : { valueOf: number; }
+>valueOf : number
+>1 : 1
+
+/** @type {Object<string, number>} */
+var paramedObject = {valueOf: 1};
+>paramedObject : { [x: string]: number; }
+>{valueOf: 1} : { valueOf: number; }
+>valueOf : number
+>1 : 1
+
+/**
+ * @param {Object} obj
+ * @return {Object}
+ */
+function returnAnyObject(obj) {
+>returnAnyObject : (obj: any) => any
+>obj : any
+
+  return obj;
+>obj : any
+}
+