Skip to content

Commit 8df1da9

Browse files
osaimolanicdard
authored andcommitted
change error message on Promise
1 parent c5f493e commit 8df1da9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/compiler/checker.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30414,7 +30414,7 @@ namespace ts {
3041430414
: min < max ? min + "-" + max
3041530415
: min;
3041630416
const error = hasRestParameter ? Diagnostics.Expected_at_least_0_arguments_but_got_1
30417-
: parameterRange === 1 && args.length === 0 && isPromiseResolveArityError(node) ? Diagnostics.Expected_0_arguments_but_got_1_Did_you_forget_to_include_void_in_your_type_argument_to_Promise
30417+
: parameterRange === 1 && args.length === 0 && isPromiseResolveArityError(node) ? Diagnostics.Expected_0_arguments_but_got_1_TypeScript_may_need_a_JSDoc_hint_that_the_call_to_new_Promise_produces_a_Promise_void
3041830418
: Diagnostics.Expected_0_arguments_but_got_1;
3041930419
if (min < args.length && args.length < max) {
3042030420
// between min and max, but with no matching overload

src/compiler/diagnosticMessages.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3309,7 +3309,7 @@
33093309
"category": "Error",
33103310
"code": 2793
33113311
},
3312-
"Expected {0} arguments, but got {1}. Did you forget to include 'void' in your type argument to 'Promise'?": {
3312+
"Expected {0} arguments, but got {1}. TypeScript may need a JSDoc hint that the call to 'new Promise()' produces a 'Promise<void>'": {
33133313
"category": "Error",
33143314
"code": 2794
33153315
},

src/services/codefixes/fixAddVoidToPromise.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ namespace ts.codefix {
33
const fixName = "addVoidToPromise";
44
const fixId = "addVoidToPromise";
55
const errorCodes = [
6-
Diagnostics.Expected_0_arguments_but_got_1_Did_you_forget_to_include_void_in_your_type_argument_to_Promise.code
6+
Diagnostics.Expected_0_arguments_but_got_1_TypeScript_may_need_a_JSDoc_hint_that_the_call_to_new_Promise_produces_a_Promise_void.code
77
];
88
registerCodeFix({
99
errorCodes,

0 commit comments

Comments
 (0)