Skip to content

Commit 744760d

Browse files
committed
Cache result of isCheckJsEnabledForFile in getSemanticDiagnosticsForFile
1 parent 31451fa commit 744760d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/compiler/program.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1273,15 +1273,16 @@ namespace ts {
12731273

12741274
Debug.assert(!!sourceFile.bindDiagnostics);
12751275

1276+
const isCheckJs = isCheckJsEnabledForFile(sourceFile, options);
12761277
// By default, only type-check .ts, .tsx, and 'External' files (external files are added by plugins)
12771278
const includeBindAndCheckDiagnostics = sourceFile.scriptKind === ScriptKind.TS || sourceFile.scriptKind === ScriptKind.TSX ||
1278-
sourceFile.scriptKind === ScriptKind.External || isCheckJsEnabledForFile(sourceFile, options);
1279+
sourceFile.scriptKind === ScriptKind.External || isCheckJs;
12791280
const bindDiagnostics = includeBindAndCheckDiagnostics ? sourceFile.bindDiagnostics : emptyArray;
12801281
const checkDiagnostics = includeBindAndCheckDiagnostics ? typeChecker.getDiagnostics(sourceFile, cancellationToken) : emptyArray;
12811282
const fileProcessingDiagnosticsInFile = fileProcessingDiagnostics.getDiagnostics(sourceFile.fileName);
12821283
const programDiagnosticsInFile = programDiagnostics.getDiagnostics(sourceFile.fileName);
12831284
let diagnostics = bindDiagnostics.concat(checkDiagnostics, fileProcessingDiagnosticsInFile, programDiagnosticsInFile);
1284-
if (isCheckJsEnabledForFile(sourceFile, options)) {
1285+
if (isCheckJs) {
12851286
diagnostics = concatenate(diagnostics, sourceFile.jsDocDiagnostics);
12861287
}
12871288
return filter(diagnostics, shouldReportDiagnostic);

0 commit comments

Comments
 (0)