fix: remove nested if

orange4glace · orange4glace · commit 6d3db109f096 · 2020-11-14T12:27:11.000+09:00
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1899,10 +1899,8 @@ namespace ts.Completions {
                     return GlobalsSearch.Continue;
                 }
                 const completionsType = typeChecker.getContextualType(objectLikeContainer, ContextFlags.Completions);
-                if (completionsType) {
-                    if (completionsType.flags & TypeFlags.Any) {
-                        return GlobalsSearch.Continue;
-                    }
+                if (completionsType && (completionsType?.flags & TypeFlags.Any)) {
+                    return GlobalsSearch.Continue;
                 }
                 isNewIdentifierLocation = hasIndexSignature(completionsType || instantiatedType);
                 typeMembers = getPropertiesForObjectExpression(instantiatedType, completionsType, objectLikeContainer, typeChecker);

Original file line number	Diff line number	Diff line change
`@@ -1899,10 +1899,8 @@ namespace ts.Completions {`
`1899`	`1899`	`return GlobalsSearch.Continue;`
`1900`	`1900`	`}`
`1901`	`1901`	`const completionsType = typeChecker.getContextualType(objectLikeContainer, ContextFlags.Completions);`
`1902`		`- if (completionsType) {`
`1903`		`- if (completionsType.flags & TypeFlags.Any) {`
`1904`		`- return GlobalsSearch.Continue;`
`1905`		`- }`
	`1902`	`+ if (completionsType && (completionsType?.flags & TypeFlags.Any)) {`
	`1903`	`+ return GlobalsSearch.Continue;`
`1906`	`1904`	`}`
`1907`	`1905`	`isNewIdentifierLocation = hasIndexSignature(completionsType \|\| instantiatedType);`
`1908`	`1906`	`typeMembers = getPropertiesForObjectExpression(instantiatedType, completionsType, objectLikeContainer, typeChecker);`