Skip to content

Commit 659e687

Browse files
committed
Remove PID-log line
1 parent 8eee11d commit 659e687

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/testRunner/externalCompileRunner.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,9 @@ function stripRushStageNumbers(result: string): string {
185185
* so we purge as much of the gulp output as we can
186186
*/
187187
function sanitizeUnimportantGulpOutput(result: string): string {
188-
return result.replace(/^.*(\] (Starting)|(Finished)).*$/gm, "").replace(/\n+/g, "\n");
188+
return result.replace(/^.*(\] (Starting)|(Finished)).*$/gm, "") // task start/end messages (nondeterministic order)
189+
.replace(/^.*\] Respawned to PID: \d+.*$/gm, "") // PID of child is OS and system-load dependent (likely stableish in a container but still dangerous)
190+
.replace(/\n+/g, "\n");
189191
}
190192

191193
function sanitizeTimestamps(result: string): string {

tests/baselines/reference/docker/vscode.log

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ Standard output:
33
yarn run vX.X.X
44
$ gulp compile --max_old_space_size=4095
55
[XX:XX:XX] Node flags detected: --max_old_space_size=4095
6-
[XX:XX:XX] Respawned to PID: 29
76
[XX:XX:XX] Using gulpfile /vscode/gulpfile.js
87
[XX:XX:XX] Error: /vscode/src/vs/workbench/browser/parts/titlebar/titlebarPart.ts(560,5): Type 'null' is not assignable to type 'string'.
98
[XX:XX:XX] Error: /vscode/src/vs/base/browser/ui/menu/menubar.ts(742,7): Type '"underline" | null' is not assignable to type 'string'.

0 commit comments

Comments
 (0)