issue reporter refactor cleanup (#212932)

* remove comments and fix new key usages

* cleanup

Author: justschen

src/vs/code/browser/issue/issue.ts

@@ -835,10 +835,6 @@ export class BaseIssueReporterService extends Disposable {
 			return false;
 		}
 		const result = await response.json();
-		// if (this.nativeHostService) {
-		// 	await this.nativeHostService.openExternal(result.html_url);
-		// }
-
 		this.window.open(result.html_url, '_blank');
 
 		this.close();
@@ -853,10 +849,6 @@ export class BaseIssueReporterService extends Disposable {
 			const url = this.getExtensionBugsUrl();
 			if (url) {
 				this.hasBeenSubmitted = true;
-				// if (this.nativeHostService) {
-				// 	await this.nativeHostService.openExternal(url);
-				// }
-
 				return true;
 			}
 		}

src/vs/code/browser/issue/issueReporterService.ts

@@ -76,15 +76,15 @@ export class IssueWebReporter extends BaseIssueReporterService {
 
 		this.addEventListener('disableExtensions', 'keydown', (e: Event) => {
 			e.stopPropagation();
-			if ((e as KeyboardEvent).key === "Enter" || (e as KeyboardEvent).key === " ") {
+			if ((e as KeyboardEvent).key === 'Enter' || (e as KeyboardEvent).key === ' ') {
 				this.issueMainService.$reloadWithExtensionsDisabled();
 			}
 		});
 
 		this.window.document.onkeydown = async (e: KeyboardEvent) => {
 			const cmdOrCtrlKey = isMacintosh ? e.metaKey : e.ctrlKey;
 			// Cmd/Ctrl+Enter previews issue and closes window
-			if (cmdOrCtrlKey && e.key === "Enter") {
+			if (cmdOrCtrlKey && e.key === 'Enter') {
 				this.delayedSubmit.trigger(async () => {
 					if (await this.createIssue()) {
 						this.close();
@@ -93,7 +93,7 @@ export class IssueWebReporter extends BaseIssueReporterService {
 			}
 
 			// Cmd/Ctrl + w closes issue window
-			if (cmdOrCtrlKey && e.key === "w") {
+			if (cmdOrCtrlKey && e.key === 'w') {
 				e.stopPropagation();
 				e.preventDefault();
 
@@ -107,20 +107,10 @@ export class IssueWebReporter extends BaseIssueReporterService {
 				}
 			}
 
-			// Cmd/Ctrl + zooms in
-			if (cmdOrCtrlKey && e.key === "+") {
-				// zoomIn(this.window);
-			}
-
-			// Cmd/Ctrl - zooms out
-			if (cmdOrCtrlKey && e.key === "-") {
-				// zoomOut(this.window);
-			}
-
 			// With latest electron upgrade, cmd+a is no longer propagating correctly for inputs in this window on mac
 			// Manually perform the selection
 			if (isMacintosh) {
-				if (cmdOrCtrlKey && e.key === "a" && e.target) {
+				if (cmdOrCtrlKey && e.key === 'a' && e.target) {
 					if (e.target instanceof HTMLInputElement || e.target instanceof HTMLTextAreaElement) {
 						(<HTMLInputElement>e.target).select();
 					}

src/vs/code/electron-sandbox/issue/issueReporterService2.ts

@@ -109,7 +109,7 @@ export class IssueReporter2 extends BaseIssueReporterService {
 		mainWindow.document.onkeydown = async (e: KeyboardEvent) => {
 			const cmdOrCtrlKey = isMacintosh ? e.metaKey : e.ctrlKey;
 			// Cmd/Ctrl+Enter previews issue and closes window
-			if (cmdOrCtrlKey && e.key === "Enter") {
+			if (cmdOrCtrlKey && e.key === 'Enter') {
 				this.delayedSubmit.trigger(async () => {
 					if (await this.createIssue()) {
 						this.close();
@@ -118,7 +118,7 @@ export class IssueReporter2 extends BaseIssueReporterService {
 			}
 
 			// Cmd/Ctrl + w closes issue window
-			if (cmdOrCtrlKey && e.key === "w") {
+			if (cmdOrCtrlKey && e.key === 'w') {
 				e.stopPropagation();
 				e.preventDefault();
 
@@ -133,19 +133,19 @@ export class IssueReporter2 extends BaseIssueReporterService {
 			}
 
 			// Cmd/Ctrl + zooms in
-			if (cmdOrCtrlKey && e.key === "+") {
+			if (cmdOrCtrlKey && (e.key === '+' || e.key === '=')) {
 				zoomIn(mainWindow);
 			}
 
 			// Cmd/Ctrl - zooms out
-			if (cmdOrCtrlKey && e.key === "-") {
+			if (cmdOrCtrlKey && e.key === '-') {
 				zoomOut(mainWindow);
 			}
 
 			// With latest electron upgrade, cmd+a is no longer propagating correctly for inputs in this window on mac
 			// Manually perform the selection
 			if (isMacintosh) {
-				if (cmdOrCtrlKey && e.key === "a" && e.target) {
+				if (cmdOrCtrlKey && e.key === 'a' && e.target) {
 					if (e.target instanceof HTMLInputElement || e.target instanceof HTMLTextAreaElement) {
 						(<HTMLInputElement>e.target).select();
 					}