Skip to content

Commit 4fb04c7

Browse files
Merge pull request #1230 from Microsoft/removeImpls
Remove unnecessary 'do nothing' implementations in SourceFileObject.
2 parents da3ae32 + 598fb71 commit 4fb04c7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/services/services.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -715,12 +715,12 @@ module ts {
715715
public filename: string;
716716
public text: string;
717717

718-
// These methods will have their implementation overridden with the implementation the
718+
// These methods will have their implementation provided by the implementation the
719719
// compiler actually exports off of SourceFile.
720-
public getLineAndCharacterFromPosition(position: number): { line: number; character: number } { return null; }
721-
public getPositionFromLineAndCharacter(line: number, character: number): number { return -1; }
722-
public getLineStarts(): number[] { return undefined; }
723-
public getSyntacticDiagnostics(): Diagnostic[] { return undefined; }
720+
public getLineAndCharacterFromPosition: (position: number) => LineAndCharacter;
721+
public getPositionFromLineAndCharacter: (line: number, character: number) => number;
722+
public getLineStarts: () => number[];
723+
public getSyntacticDiagnostics: () => Diagnostic[];
724724

725725
public amdDependencies: string[];
726726
public amdModuleName: string;

0 commit comments

Comments
 (0)