Skip to content

Commit 47f48d3

Browse files
Apply same single-line style to copied nodes as manufactured ones (#57890)
Co-authored-by: TypeScript Bot <[email protected]>
1 parent 32a1370 commit 47f48d3

File tree

503 files changed

+1411
-1406
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

503 files changed

+1411
-1406
lines changed

src/compiler/checker.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ import {
272272
getEffectiveTypeParameterDeclarations,
273273
getElementOrPropertyAccessName,
274274
getEmitDeclarations,
275+
getEmitFlags,
275276
getEmitModuleKind,
276277
getEmitModuleResolutionKind,
277278
getEmitScriptTarget,
@@ -632,6 +633,7 @@ import {
632633
isLiteralTypeNode,
633634
isLogicalOrCoalescingBinaryExpression,
634635
isLogicalOrCoalescingBinaryOperator,
636+
isMappedTypeNode,
635637
isMetaProperty,
636638
isMethodDeclaration,
637639
isMethodSignature,
@@ -8620,7 +8622,6 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
86208622
cancellationToken.throwIfCancellationRequested();
86218623
}
86228624
let hadError = false;
8623-
const file = getSourceFileOfNode(existing);
86248625
const transformed = visitNode(existing, visitExistingNodeTreeSymbols, isTypeNode);
86258626
if (hadError) {
86268627
return undefined;
@@ -8756,8 +8757,12 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
87568757
}
87578758
}
87588759

8759-
if (file && isTupleTypeNode(node) && !nodeIsSynthesized(node) && (getLineAndCharacterOfPosition(file, node.pos).line === getLineAndCharacterOfPosition(file, node.end).line)) {
8760-
setEmitFlags(node, EmitFlags.SingleLine);
8760+
if (isTupleTypeNode(node) || isTypeLiteralNode(node) || isMappedTypeNode(node)) {
8761+
const visited = visitEachChild(node, visitExistingNodeTreeSymbols, /*context*/ undefined);
8762+
const clone = setTextRange(visited === node ? factory.cloneNode(node) : visited, node);
8763+
const flags = getEmitFlags(clone);
8764+
setEmitFlags(clone, flags | (context.flags & NodeBuilderFlags.MultilineObjectLiterals && isTypeLiteralNode(node) ? 0 : EmitFlags.SingleLine));
8765+
return clone;
87618766
}
87628767

87638768
return visitEachChild(node, visitExistingNodeTreeSymbols, /*context*/ undefined);

tests/baselines/reference/ExportObjectLiteralAndObjectTypeLiteralWithAccessibleTypesInNestedMemberTypeAnnotations.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module A {
1313
}
1414

1515
export var UnitSquare : {
16-
>UnitSquare : { top: { left: Point; right: Point;}; bottom: { left: Point; right: Point;}; }
16+
>UnitSquare : { top: { left: Point; right: Point; }; bottom: { left: Point; right: Point; }; }
1717

1818
top: { left: Point, right: Point },
1919
>top : { left: Point; right: Point; }

tests/baselines/reference/FunctionAndModuleWithSameNameAndCommonRoot.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module A {
3535

3636
=== test.ts ===
3737
var fn: () => { x: number; y: number };
38-
>fn : () => { x: number; y: number;}
38+
>fn : () => { x: number; y: number; }
3939
>x : number
4040
>y : number
4141

tests/baselines/reference/FunctionAndModuleWithSameNameAndDifferentCommonRoot.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module B {
3535

3636
=== test.ts ===
3737
var fn: () => { x: number; y: number };
38-
>fn : () => { x: number; y: number;}
38+
>fn : () => { x: number; y: number; }
3939
>x : number
4040
>y : number
4141

tests/baselines/reference/ModuleWithExportedAndNonExportedImportAlias.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ var p = Geometry.Origin;
8484
>Origin : A.Point
8585

8686
var line: { start: { x: number; y: number }; end: { x: number; y: number; } };
87-
>line : { start: { x: number; y: number;}; end: { x: number; y: number;}; }
87+
>line : { start: { x: number; y: number; }; end: { x: number; y: number; }; }
8888
>start : { x: number; y: number; }
8989
>x : number
9090
>y : number

tests/baselines/reference/accessorsOverrideProperty8.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type AnyCtor<P extends object> = new (...a: any[]) => P
1616
>a : any[]
1717

1818
declare function classWithProperties<T extends { [key: string]: Types }, P extends object>(properties: T, klass: AnyCtor<P>): {
19-
>classWithProperties : <T extends { [key: string]: Types; }, P extends object>(properties: T, klass: AnyCtor<P>) => { new (): P & Properties<T>; prototype: P & Properties<T>;}
19+
>classWithProperties : <T extends { [key: string]: Types; }, P extends object>(properties: T, klass: AnyCtor<P>) => { new (): P & Properties<T>; prototype: P & Properties<T>; }
2020
>key : string
2121
>properties : T
2222
>klass : AnyCtor<P>

tests/baselines/reference/aliasUsageInObjectLiteral.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ var b: { x: IHasVisualizationModel } = { x: moduleA };
3030
>moduleA : typeof moduleA
3131

3232
var c: { y: { z: IHasVisualizationModel } } = { y: { z: moduleA } };
33-
>c : { y: { z: IHasVisualizationModel;}; }
33+
>c : { y: { z: IHasVisualizationModel; }; }
3434
>y : { z: IHasVisualizationModel; }
3535
>z : IHasVisualizationModel
3636
>{ y: { z: moduleA } } : { y: { z: typeof moduleA; }; }

tests/baselines/reference/annotatedThisPropertyInitializerDoesntNarrow.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// from webpack/lib/Compilation.js and filed at #26427
55
/** @param {{ [s: string]: number }} map */
66
function mappy(map) {}
7-
>mappy : (map: { [s: string]: number;}) => void
7+
>mappy : (map: { [s: string]: number; }) => void
88
>map : { [s: string]: number; }
99

1010
export class C {

tests/baselines/reference/anonterface.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module M {
88
>C : C
99

1010
m(fn:{ (n:number):string; },n2:number):string {
11-
>m : (fn: { (n: number): string;}, n2: number) => string
11+
>m : (fn: { (n: number): string; }, n2: number) => string
1212
>fn : (n: number) => string
1313
>n : number
1414
>n2 : number

tests/baselines/reference/anyAssignabilityInInheritance.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ var r3 = foo3(a); // any
8585
>a : any
8686

8787
declare function foo7(x: { bar: number }): { bar: number };
88-
>foo7 : { (x: { bar: number;}): { bar: number;}; (x: any): any; }
88+
>foo7 : { (x: { bar: number; }): { bar: number; }; (x: any): any; }
8989
>x : { bar: number; }
9090
>bar : number
9191
>bar : number

tests/baselines/reference/argumentExpressionContextualTyping.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var o = { x: ["string", 1], y: { c: true, d: "world", e: 3 } };
4747
>3 : 3
4848

4949
var o1: { x: [string, number], y: { c: boolean, d: string, e: number } } = { x: ["string", 1], y: { c: true, d: "world", e: 3 } };
50-
>o1 : { x: [string, number]; y: { c: boolean; d: string; e: number;}; }
50+
>o1 : { x: [string, number]; y: { c: boolean; d: string; e: number; }; }
5151
>x : [string, number]
5252
>y : { c: boolean; d: string; e: number; }
5353
>c : boolean

tests/baselines/reference/arrayLiteralContextualType.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function foo(animals: IAnimal[]) { }
3535
>animals : IAnimal[]
3636

3737
function bar(animals: { [n: number]: IAnimal }) { }
38-
>bar : (animals: { [n: number]: IAnimal;}) => void
38+
>bar : (animals: { [n: number]: IAnimal; }) => void
3939
>animals : { [n: number]: IAnimal; }
4040
>n : number
4141

tests/baselines/reference/arrayLiteralWithMultipleBestCommonTypes.types

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,28 +58,28 @@ var es = [(x: string) => 2, (x: Object) => 1]; // { (x:string) => number }[]
5858
>1 : 1
5959

6060
var fs = [(a: { x: number; y?: number }) => 1, (b: { x: number; z?: number }) => 2]; // (a: { x: number; y?: number }) => number[]
61-
>fs : (((a: { x: number; y?: number;}) => number) | ((b: { x: number; z?: number;}) => number))[]
62-
>[(a: { x: number; y?: number }) => 1, (b: { x: number; z?: number }) => 2] : (((a: { x: number; y?: number;}) => number) | ((b: { x: number; z?: number;}) => number))[]
63-
>(a: { x: number; y?: number }) => 1 : (a: { x: number; y?: number;}) => number
61+
>fs : (((a: { x: number; y?: number; }) => number) | ((b: { x: number; z?: number; }) => number))[]
62+
>[(a: { x: number; y?: number }) => 1, (b: { x: number; z?: number }) => 2] : (((a: { x: number; y?: number; }) => number) | ((b: { x: number; z?: number; }) => number))[]
63+
>(a: { x: number; y?: number }) => 1 : (a: { x: number; y?: number; }) => number
6464
>a : { x: number; y?: number; }
6565
>x : number
6666
>y : number
6767
>1 : 1
68-
>(b: { x: number; z?: number }) => 2 : (b: { x: number; z?: number;}) => number
68+
>(b: { x: number; z?: number }) => 2 : (b: { x: number; z?: number; }) => number
6969
>b : { x: number; z?: number; }
7070
>x : number
7171
>z : number
7272
>2 : 2
7373

7474
var gs = [(b: { x: number; z?: number }) => 2, (a: { x: number; y?: number }) => 1]; // (b: { x: number; z?: number }) => number[]
75-
>gs : (((b: { x: number; z?: number;}) => number) | ((a: { x: number; y?: number;}) => number))[]
76-
>[(b: { x: number; z?: number }) => 2, (a: { x: number; y?: number }) => 1] : (((b: { x: number; z?: number;}) => number) | ((a: { x: number; y?: number;}) => number))[]
77-
>(b: { x: number; z?: number }) => 2 : (b: { x: number; z?: number;}) => number
75+
>gs : (((b: { x: number; z?: number; }) => number) | ((a: { x: number; y?: number; }) => number))[]
76+
>[(b: { x: number; z?: number }) => 2, (a: { x: number; y?: number }) => 1] : (((b: { x: number; z?: number; }) => number) | ((a: { x: number; y?: number; }) => number))[]
77+
>(b: { x: number; z?: number }) => 2 : (b: { x: number; z?: number; }) => number
7878
>b : { x: number; z?: number; }
7979
>x : number
8080
>z : number
8181
>2 : 2
82-
>(a: { x: number; y?: number }) => 1 : (a: { x: number; y?: number;}) => number
82+
>(a: { x: number; y?: number }) => 1 : (a: { x: number; y?: number; }) => number
8383
>a : { x: number; y?: number; }
8484
>x : number
8585
>y : number

tests/baselines/reference/arraySigChecking.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ myArray = [[1, 2]];
5252
>2 : 2
5353

5454
function isEmpty(l: { length: number }) {
55-
>isEmpty : (l: { length: number;}) => boolean
55+
>isEmpty : (l: { length: number; }) => boolean
5656
>l : { length: number; }
5757
>length : number
5858

tests/baselines/reference/assignmentCompatBug5.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
=== assignmentCompatBug5.ts ===
44
function foo1(x: { a: number; }) { }
5-
>foo1 : (x: { a: number;}) => void
5+
>foo1 : (x: { a: number; }) => void
66
>x : { a: number; }
77
>a : number
88

tests/baselines/reference/assignmentCompatFunctionsWithOptionalArgs.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
=== assignmentCompatFunctionsWithOptionalArgs.ts ===
44
function foo(x: { id: number; name?: string; }): void;
5-
>foo : (x: { id: number; name?: string;}) => void
5+
>foo : (x: { id: number; name?: string; }) => void
66
>x : { id: number; name?: string; }
77
>id : number
88
>name : string

tests/baselines/reference/assignmentCompatOnNew.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class Foo{};
55
>Foo : Foo
66

77
function bar(x: {new(): Foo;}){}
8-
>bar : (x: { new (): Foo;}) => void
8+
>bar : (x: { new (): Foo; }) => void
99
>x : new () => Foo
1010

1111
bar(Foo); // Error, but should be allowed

tests/baselines/reference/assignmentCompatWithCallSignatures3.types

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ var a10: (...x: Derived[]) => Derived;
7676
>x : Derived[]
7777

7878
var a11: (x: { foo: string }, y: { foo: string; bar: string }) => Base;
79-
>a11 : (x: { foo: string;}, y: { foo: string; bar: string;}) => Base
79+
>a11 : (x: { foo: string; }, y: { foo: string; bar: string; }) => Base
8080
>x : { foo: string; }
8181
>foo : string
8282
>y : { foo: string; bar: string; }
@@ -94,7 +94,7 @@ var a13: (x: Array<Base>, y: Array<Derived>) => Array<Derived>;
9494
>y : Derived[]
9595

9696
var a14: (x: { a: string; b: number }) => Object;
97-
>a14 : (x: { a: string; b: number;}) => Object
97+
>a14 : (x: { a: string; b: number; }) => Object
9898
>x : { a: string; b: number; }
9999
>a : string
100100
>b : number
@@ -130,7 +130,7 @@ var a17: {
130130

131131
};
132132
var a18: {
133-
>a18 : { (x: { (a: number): number; (a: string): string;}): any[]; (x: { (a: boolean): boolean; (a: Date): Date;}): any[]; }
133+
>a18 : { (x: { (a: number): number; (a: string): string; }): any[]; (x: { (a: boolean): boolean; (a: Date): Date; }): any[]; }
134134

135135
(x: {
136136
>x : { (a: number): number; (a: string): string; }
@@ -276,10 +276,10 @@ b8 = a8; // ok
276276
>a8 : (x: (arg: Base) => Derived, y: (arg2: Base) => Derived) => (r: Base) => Derived
277277

278278
var b9: <T extends Base, U extends Derived>(x: (arg: T) => U, y: (arg2: { foo: string; bing: number }) => U) => (r: T) => U;
279-
>b9 : <T extends Base, U extends Derived>(x: (arg: T) => U, y: (arg2: { foo: string; bing: number;}) => U) => (r: T) => U
279+
>b9 : <T extends Base, U extends Derived>(x: (arg: T) => U, y: (arg2: { foo: string; bing: number; }) => U) => (r: T) => U
280280
>x : (arg: T) => U
281281
>arg : T
282-
>y : (arg2: { foo: string; bing: number;}) => U
282+
>y : (arg2: { foo: string; bing: number; }) => U
283283
>arg2 : { foo: string; bing: number; }
284284
>foo : string
285285
>bing : number
@@ -355,7 +355,7 @@ b13 = a13; // ok
355355
>a13 : (x: Base[], y: Derived[]) => Derived[]
356356

357357
var b14: <T>(x: { a: T; b: T }) => T;
358-
>b14 : <T>(x: { a: T; b: T;}) => T
358+
>b14 : <T>(x: { a: T; b: T; }) => T
359359
>x : { a: T; b: T; }
360360
>a : T
361361
>b : T

tests/baselines/reference/assignmentCompatWithCallSignatures4.types

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module Errors {
5252
>x : Base[]
5353

5454
var a11: (x: { foo: string }, y: { foo: string; bar: string }) => Base;
55-
>a11 : (x: { foo: string;}, y: { foo: string; bar: string;}) => Base
55+
>a11 : (x: { foo: string; }, y: { foo: string; bar: string; }) => Base
5656
>x : { foo: string; }
5757
>foo : string
5858
>y : { foo: string; bar: string; }
@@ -75,13 +75,13 @@ module Errors {
7575

7676
};
7777
var a15: (x: { a: string; b: number }) => number;
78-
>a15 : (x: { a: string; b: number;}) => number
78+
>a15 : (x: { a: string; b: number; }) => number
7979
>x : { a: string; b: number; }
8080
>a : string
8181
>b : number
8282

8383
var a16: {
84-
>a16 : { (x: { (a: number): number; (a?: number): number;}): number[]; (x: { (a: boolean): boolean; (a?: boolean): boolean;}): boolean[]; }
84+
>a16 : { (x: { (a: number): number; (a?: number): number; }): number[]; (x: { (a: boolean): boolean; (a?: boolean): boolean; }): boolean[]; }
8585

8686
(x: {
8787
>x : { (a: number): number; (a?: number): number; }
@@ -160,10 +160,10 @@ module Errors {
160160
>a7 : (x: (arg: Base) => Derived) => (r: Base) => Derived2
161161

162162
var b8: <T extends Base, U extends Derived>(x: (arg: T) => U, y: (arg2: { foo: number; }) => U) => (r: T) => U;
163-
>b8 : <T extends Base, U extends Derived>(x: (arg: T) => U, y: (arg2: { foo: number;}) => U) => (r: T) => U
163+
>b8 : <T extends Base, U extends Derived>(x: (arg: T) => U, y: (arg2: { foo: number; }) => U) => (r: T) => U
164164
>x : (arg: T) => U
165165
>arg : T
166-
>y : (arg2: { foo: number;}) => U
166+
>y : (arg2: { foo: number; }) => U
167167
>arg2 : { foo: number; }
168168
>foo : number
169169
>r : T
@@ -224,7 +224,7 @@ module Errors {
224224
>a12 : (x: Base[], y: Derived2[]) => Derived[]
225225

226226
var b15: <T>(x: { a: T; b: T }) => T;
227-
>b15 : <T>(x: { a: T; b: T;}) => T
227+
>b15 : <T>(x: { a: T; b: T; }) => T
228228
>x : { a: T; b: T; }
229229
>a : T
230230
>b : T
@@ -240,7 +240,7 @@ module Errors {
240240
>a15 : (x: { a: string; b: number; }) => number
241241

242242
var b15a: <T extends Base>(x: { a: T; b: T }) => number;
243-
>b15a : <T extends Base>(x: { a: T; b: T;}) => number
243+
>b15a : <T extends Base>(x: { a: T; b: T; }) => number
244244
>x : { a: T; b: T; }
245245
>a : T
246246
>b : T

tests/baselines/reference/assignmentCompatWithCallSignatures5.types

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,21 +50,21 @@ var a6: <T extends Base>(x: (arg: T) => Derived) => T;
5050
>arg : T
5151

5252
var a11: <T>(x: { foo: T }, y: { foo: T; bar: T }) => Base;
53-
>a11 : <T>(x: { foo: T;}, y: { foo: T; bar: T;}) => Base
53+
>a11 : <T>(x: { foo: T; }, y: { foo: T; bar: T; }) => Base
5454
>x : { foo: T; }
5555
>foo : T
5656
>y : { foo: T; bar: T; }
5757
>foo : T
5858
>bar : T
5959

6060
var a15: <T>(x: { a: T; b: T }) => T[];
61-
>a15 : <T>(x: { a: T; b: T;}) => T[]
61+
>a15 : <T>(x: { a: T; b: T; }) => T[]
6262
>x : { a: T; b: T; }
6363
>a : T
6464
>b : T
6565

6666
var a16: <T extends Base>(x: { a: T; b: T }) => T[];
67-
>a16 : <T extends Base>(x: { a: T; b: T;}) => T[]
67+
>a16 : <T extends Base>(x: { a: T; b: T; }) => T[]
6868
>x : { a: T; b: T; }
6969
>a : T
7070
>b : T
@@ -194,7 +194,7 @@ b6 = a6; // ok
194194
>a6 : <T extends Base>(x: (arg: T) => Derived) => T
195195

196196
var b11: <T, U>(x: { foo: T }, y: { foo: U; bar: U }) => Base;
197-
>b11 : <T, U>(x: { foo: T;}, y: { foo: U; bar: U;}) => Base
197+
>b11 : <T, U>(x: { foo: T; }, y: { foo: U; bar: U; }) => Base
198198
>x : { foo: T; }
199199
>foo : T
200200
>y : { foo: U; bar: U; }
@@ -212,7 +212,7 @@ b11 = a11; // ok
212212
>a11 : <T>(x: { foo: T; }, y: { foo: T; bar: T; }) => Base
213213

214214
var b15: <U, V>(x: { a: U; b: V; }) => U[];
215-
>b15 : <U, V>(x: { a: U; b: V;}) => U[]
215+
>b15 : <U, V>(x: { a: U; b: V; }) => U[]
216216
>x : { a: U; b: V; }
217217
>a : U
218218
>b : V
@@ -228,7 +228,7 @@ b15 = a15; // ok
228228
>a15 : <T>(x: { a: T; b: T; }) => T[]
229229

230230
var b16: <T>(x: { a: T; b: T }) => T[];
231-
>b16 : <T>(x: { a: T; b: T;}) => T[]
231+
>b16 : <T>(x: { a: T; b: T; }) => T[]
232232
>x : { a: T; b: T; }
233233
>a : T
234234
>b : T

0 commit comments

Comments
 (0)