Skip to content

Commit 3b684d4

Browse files
committed
PR feedback
1 parent b5f1169 commit 3b684d4

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/compiler/checker.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5186,24 +5186,16 @@ namespace ts {
51865186
case SyntaxKind.ClassDeclaration:
51875187
case SyntaxKind.ClassExpression:
51885188
case SyntaxKind.TypeLiteral:
5189-
resolveDynamicMembersOfClassOrInterfaceOrTypeLiteralNode(<ClassLikeDeclaration | InterfaceDeclaration | TypeLiteralNode>node, symbolTable);
5189+
resolveDynamicMembersOfNode(node, (<ClassLikeDeclaration | InterfaceDeclaration | TypeLiteralNode>node).members, symbolTable);
51905190
break;
51915191
case SyntaxKind.ObjectLiteralExpression:
5192-
resolveDynamicMembersOfObjectLiteralExpression(<ObjectLiteralExpression>node, symbolTable);
5192+
resolveDynamicMembersOfNode(node, (<ObjectLiteralExpression>node).properties, symbolTable);
51935193
break;
51945194
}
51955195
}
51965196

5197-
function resolveDynamicMembersOfClassOrInterfaceOrTypeLiteralNode(node: ClassLikeDeclaration | InterfaceDeclaration | TypeLiteralNode, symbolTable: SymbolTable) {
5198-
for (const member of node.members) {
5199-
if (member.name && isComputedPropertyName(member.name) && isEntityNameExpression(member.name.expression)) {
5200-
bindDynamicMember(symbolTable, node.symbol, member);
5201-
}
5202-
}
5203-
}
5204-
5205-
function resolveDynamicMembersOfObjectLiteralExpression(node: ObjectLiteralExpression, symbolTable: SymbolTable) {
5206-
for (const member of node.properties) {
5197+
function resolveDynamicMembersOfNode(node: Declaration, members: NodeArray<ClassElement | TypeElement | ObjectLiteralElement>, symbolTable: SymbolTable) {
5198+
for (const member of members) {
52075199
if (member.name && isComputedPropertyName(member.name) && isEntityNameExpression(member.name.expression)) {
52085200
bindDynamicMember(symbolTable, node.symbol, member);
52095201
}

0 commit comments

Comments
 (0)