Merge branch 'main' into eslint-prefer-rest

Author: jakebailey

.devcontainer/Dockerfile

@@ -1,7 +1,7 @@
-# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.154.0/containers/javascript-node/.devcontainer/base.Dockerfile
+# See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/javascript-node/.devcontainer/base.Dockerfile
 
-# [Choice] Node.js version: 14, 12, 10
-ARG VARIANT="14-buster"
+# [Choice] Node.js version: 18, 16, 14
+ARG VARIANT="18-buster"
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
 
 RUN sudo -u node npm install -g hereby

.devcontainer/devcontainer.json

@@ -3,20 +3,24 @@
     "build": {
         "dockerfile": "Dockerfile",
         "args": {
-            "VARIANT": "14"
+            "VARIANT": "18"
         }
     },
-    "settings": {
-        "terminal.integrated.defaultProfile.linux": "bash",
-        "terminal.integrated.profiles.linux": {
-            "bash": {
-                "path": "/bin/bash",
-                "icon": "terminal-bash",
+    "customizations": {
+        "vscode": {
+            "settings": {
+                "terminal.integrated.defaultProfile.linux": "bash",
+                "terminal.integrated.profiles.linux": {
+                    "bash": {
+                        "path": "/bin/bash",
+                        "icon": "terminal-bash"
+                    }
+                }
             },
-        },
+            "extensions": [
+                "dbaeumer.vscode-eslint"
+            ]
+        }
     },
-    "extensions": [
-        "dbaeumer.vscode-eslint"
-    ],
     "remoteUser": "node"
-}
+}

.eslintrc.json

@@ -84,6 +84,7 @@
         "@typescript-eslint/class-literal-property-style": "off",
         "@typescript-eslint/consistent-indexed-object-style": "off",
         "@typescript-eslint/no-duplicate-enum-values": "off",
+        "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-namespace": "off",
         "@typescript-eslint/no-non-null-asserted-optional-chain": "off",
         "@typescript-eslint/no-var-requires": "off",
@@ -103,8 +104,6 @@
         ],
 
         // Todo: For each of these, investigate whether we want to enable them ✨
-        "no-useless-escape": "off",
-        "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-unused-vars": "off",
 
         // Pending https://github.com/typescript-eslint/typescript-eslint/issues/4820

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -0,0 +1,99 @@
+name: "Bug report"
+description: "Create a report to help us improve TypeScript"
+body:
+  - type: markdown
+    attributes:
+      value: Please fill in each section completely. Thank you!
+  - type: textarea
+    id: search_terms
+    attributes:
+      label: "🔎 Search Terms"
+      description: |
+        What search terms did you use when trying to find an existing bug report?
+
+        List them here so people in the future can find this one more easily.
+      placeholder: |
+        List of keywords you searched for before creating this issue.
+        Write them down here so that others can find this bug more easily and help provide feedback.
+
+        e.g. "function inference any", "jsx attribute spread", "move to file duplicate imports", "discriminated union inference", "ts2822"
+    validations:
+      required: true
+  - type: textarea
+    id: version_info
+    attributes:
+      label: "🕗 Version & Regression Information"
+      description: |
+        When did you start seeing this bug occur?
+
+        "Bugs" that have existed in TS for a long time are very likely to be FAQs; refer to
+        https://github.com/Microsoft/TypeScript/wiki/FAQ#common-bugs-that-arent-bugs
+
+
+        If possible, please try testing the nightly version of TS to see if it's already been fixed. For npm: `typescript@next`
+
+        This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
+  
+
+        Note: The TypeScript Playground can be used to try older versions of TypeScript.
+
+        Please keep and fill in the line that best applies.
+      value: |
+        - This is a crash
+        - This changed between versions ______ and _______
+        - This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
+        - I was unable to test this on prior versions because _______
+    validations:
+      required: true
+  - type: input
+    id: playground_link
+    attributes:
+      label: ⏯ Playground Link
+      description: |
+        A link to a TypeScript Playground "Share" link which shows this behavior.
+
+        This should have the same code as the code snippet below, and use whichever settings are relevant to your report.
+
+
+        As a last resort, you can link to a repo, but these will be slower for us to investigate.
+      placeholder: "Playground link with relevant code: https://www.typescriptlang.org/play?#code/PTAEFkE9QYwewCYFNQHM5IM6gBZIE5JA"
+    validations:
+      required: false
+  - type: textarea
+    id: code
+    attributes:
+      label: 💻 Code
+      description: |
+        Please post the relevant code sample here as well.
+        This code and the Playground code should be the same, do not use separate examples.
+
+        We can quickly address your report if:
+
+          - The code sample is short. Nearly all TypeScript bugs can be demonstrated in 20-30 lines of code!
+          - It doesn't use external libraries. These are often issues with the type definitions rather than TypeScript bugs.
+          - The incorrectness of the behavior is readily apparent from reading the sample.
+
+        Reports are slower to investigate if:
+          - We have to pare too much extraneous code.
+          - We have to clone a large repo and validate that the problem isn't elsewhere.
+          - The sample is confusing or doesn't clearly demonstrate what's wrong.
+      value: |
+        ```ts
+        // Your code here
+        ```
+    validations:
+      required: false
+  - type: textarea
+    id: actual_behavior
+    attributes:
+      label: 🙁 Actual behavior
+      description: "What happened, and why it was wrong."
+    validations:
+      required: true
+  - type: textarea
+    id: expected_behavior
+    attributes:
+      label: 🙂 Expected behavior
+      description: What you expected to happen instead, and why
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/Feature_request.md

@@ -0,0 +1,70 @@
+name: "Feature request"
+description: "Suggest an idea"
+body:
+  - type: markdown
+    attributes:
+      value: "Please fill in each section completely. Thank you!"
+  - type: textarea
+    id: search_terms
+    attributes:
+      label: "🔍 Search Terms"
+      description: |
+          💡 Did you know? TypeScript has over 2,000 open suggestions!
+
+          🔎 Please search thoroughly before logging new feature requests as most common ideas already have a proposal in progress.
+
+          The "Common Feature Requests" section of the FAQ lists many popular requests: https://github.com/Microsoft/TypeScript/wiki/FAQ#common-feature-requests
+      placeholder: |
+        List of keywords you searched for before creating this issue.
+        Write them down here so that others can find this suggestion more easily and help provide feedback.
+
+        e.g. "isArray readonly", "regex string types", "json const assertion import"
+    validations:
+      required: true
+  - type: checkboxes
+    id: viability_checklist
+    attributes:
+      label: "✅ Viability Checklist"
+      description: |
+        Suggestions that don't meet all these criteria are very, very unlikely to be accepted.
+        We always recommend reviewing the TypeScript design goals before investing time writing
+        a proposal for ideas outside the scope of the project.
+
+        My suggestion meets the following guidelines.
+      options:
+      - label: This wouldn't be a breaking change in existing TypeScript/JavaScript code
+        required: true
+      - label: This wouldn't change the runtime behavior of existing JavaScript code
+        required: true
+      - label: This could be implemented without emitting different JS based on the types of the expressions
+        required: true
+      - label: This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
+        required: true
+      - label: "This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals"
+        required: true
+  - type: textarea
+    id: suggestion_summary
+    attributes:
+      label: "⭐ Suggestion"
+      description: "A summary of what you'd like to see added or changed"
+    validations:
+      required: true
+  - type: textarea
+    id: motivating_example
+    attributes:
+      label: "📃 Motivating Example"
+      description: |
+          If you were announcing this feature in a blog post, what's a short
+          explanation that shows a developer why this feature improves the language?
+    validations:
+      required: true
+  - type: textarea
+    id: use_cases
+    attributes:
+      label: "💻 Use Cases"
+      value: |
+        1. What do you want to use this for?
+        2. What shortcomings exist with current approaches?
+        3. What workarounds are you using in the meantime?
+    validations:
+      required: true