rename convert to named parameters (#30401)

Author: gabritto

src/compiler/diagnosticMessages.json

@@ -4927,7 +4927,7 @@
         "category": "Message",
         "code": 95074
     },
-    "Convert to named parameters": {
+    "Convert parameters to destructured object": {
         "category": "Message",
         "code": 95075
     }

src/services/refactors/convertToNamedParameters.ts renamed to src/services/refactors/convertParamsToDestructuredObject.ts

@@ -1,6 +1,6 @@
 /* @internal */
-namespace ts.refactor.convertToNamedParameters {
-    const refactorName = "Convert to named parameters";
+namespace ts.refactor.convertParamsToDestructuredObject {
+    const refactorName = "Convert parameters to destructured object";
     const minimumParameterLength = 2;
     registerRefactor(refactorName, { getEditsForAction, getAvailableActions });
 
@@ -12,7 +12,7 @@ namespace ts.refactor.convertToNamedParameters {
         const functionDeclaration = getFunctionDeclarationAtPosition(file, startPosition, context.program.getTypeChecker());
         if (!functionDeclaration) return emptyArray;
 
-        const description = getLocaleSpecificMessage(Diagnostics.Convert_to_named_parameters);
+        const description = getLocaleSpecificMessage(Diagnostics.Convert_parameters_to_destructured_object);
         return [{
             name: refactorName,
             description,

src/services/tsconfig.json

@@ -84,7 +84,7 @@
         "refactors/generateGetAccessorAndSetAccessor.ts",
         "refactors/moveToNewFile.ts",
         "refactors/addOrRemoveBracesToArrowFunction.ts",
-        "refactors/convertToNamedParameters.ts",
+        "refactors/convertParamsToDestructuredObject.ts",
         "services.ts",
         "breakpoints.ts",
         "transform.ts",

tests/cases/fourslash/refactorConvertToNamedParameters_allParamsOptional.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_allParamsOptional.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b = "1" }: { a?: number; b?: string; } = {}): string {
     return b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_arrowFunction.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_arrowFunction.ts

@@ -5,9 +5,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const foo = ({ a, b }: { a: number; b: number; }) => { };
 foo({ a: 1, b: 2 });`
 });

tests/cases/fourslash/refactorConvertToNamedParameters_arrowFunctionWithContextualType.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_arrowFunctionWithType.ts

@@ -4,4 +4,4 @@
 ////foo(1, 2);
 
 goTo.select("a", "b");
-verify.not.refactorAvailable("Convert to named parameters");
+verify.not.refactorAvailable("Convert parameters to destructured object");

tests/cases/fourslash/refactorConvertToNamedParameters_callComments.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_callComments.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b, rest = [] }: { a: number; b: number; rest?: number[]; }) {
     return a + b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_callComments2.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_callComments2.ts

@@ -16,9 +16,9 @@
 goTo.select("a", "b");
 /* The expected content is currently wrong. The new argument object has the wrong formatting. */
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b, rest = [] }: { a: number; b: number; rest?: number[]; }) {
     return a + b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_chainedCall.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_chainedCall.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b }: { a: number; b: number; }) {
     return { bar: () => a + b };
 }

tests/cases/fourslash/refactorConvertToNamedParameters_classDeclarationAliasing.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_classDeclarationAliasing.ts

@@ -9,9 +9,9 @@
 goTo.select("a", "b");
 // Refactor should not make changes
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     constructor(a: number, b: number) { }
 }

tests/cases/fourslash/refactorConvertToNamedParameters_classDeclarationGoodUsages.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_classDeclarationGoodUsages.ts

@@ -14,9 +14,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class C {
     static a: number = 2;
     constructor({ a, b }: { a: number; b: number; }) { }

tests/cases/fourslash/refactorConvertToNamedParameters_classExpression.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_classExpression.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const c = class {
     constructor({ a, b = { x: 1 } }: { a: number; b?: { x: number; }; }) { }
 }

tests/cases/fourslash/refactorConvertToNamedParameters_classExpressionGoodUsages.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_classExpressionGoodUsages.ts

@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const c = class C {
     static a: number = 2;
     constructor({ a, b }: { a: number; b: number; }) { }

tests/cases/fourslash/refactorConvertToNamedParameters_classExpressionHeritage.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_classExpressionHeritage.ts

@@ -12,9 +12,9 @@
 goTo.select("a", "b");
 // Refactor should not make changes
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const foo = class Foo {
     constructor(a: number, b: number) { }
 }

tests/cases/fourslash/refactorConvertToNamedParameters_classTypeParameters.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_classTypeParameters.ts

@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo<T> {
     bar({ t, s }: { t: T; s: T; }) {
         return s;

tests/cases/fourslash/refactorConvertToNamedParameters_constructor.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_constructor.ts

@@ -12,9 +12,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     t: string;
     s: string;

tests/cases/fourslash/refactorConvertToNamedParameters_defaultClass.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_defaultClass.ts

@@ -5,4 +5,4 @@
 ////}
 
 goTo.select("a", "b");
-verify.not.refactorAvailable("Convert to named parameters");
+verify.not.refactorAvailable("Convert parameters to destructured object");

tests/cases/fourslash/refactorConvertToNamedParameters_function.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_function.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b }: { a: number; b: string; }): string {
     return b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_functionComments.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_functionComments.ts

@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `foo({ a: 1, b: 2 }); /**a*/
 /**b*/ function foo(/**this1*/ this /**this2*/: /**void1*/ void /**void2*/, { a, b = /**k*/ 1 /**l*/ }: { /**c*/ a /**d*/: /**e*/ number /**f*/; /**g*/ b /**h*/?: /**i*/ number /**j*/; }) {
     // m

tests/cases/fourslash/refactorConvertToNamedParameters_functionComments1.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_functionComments1.ts

@@ -6,9 +6,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b }: { a: number /** a */; b: number /** b */; }) {
     return a + b;
 }`

tests/cases/fourslash/refactorConvertToNamedParameters_functionComments2.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_functionComments2.ts

@@ -11,9 +11,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo(// comment
 { a, b }: {
     // a comment

tests/cases/fourslash/refactorConvertToNamedParameters_functionExpression.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_functionExpression.ts

@@ -5,9 +5,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const foo = function({ a, b }: { a: number; b: number; }) { };
 foo({ a: 1, b: 2 });`
 });

tests/cases/fourslash/refactorConvertToNamedParameters_functionTypeParameters.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_functionTypeParameters.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo<T, S>({ t, s }: { t: T; s: S; }) {
     return s;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_inheritedConstructor.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_inheritedConstructor.ts

@@ -12,9 +12,9 @@ goTo.select("a", "b");
     `new Bar("a", "b")` should be modified by the refactor to be `new Bar({ t: "a", s: "b" })`
 */
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     constructor({ t, s }: { t: string; s: string; }) { }
 }

tests/cases/fourslash/refactorConvertToNamedParameters_inheritedMethod.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_inheritedMethod.ts

@@ -11,9 +11,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     bar({ t, s }: { t: string; s: string; }): string {
         return s + t;

tests/cases/fourslash/refactorConvertToNamedParameters_initializer.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_initializer.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b = "1" }: { a: number; b?: string; }): string {
     return b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_initializerInference.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_initializerInference.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b = { x: 1, z: { s: true } } }: { a: number; b?: { x: number; z: { s: boolean; }; }; }) {
     return b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_method.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_method.ts

@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     bar({ t, s }: { t: string; s: string; }): string {
         return s + t;

tests/cases/fourslash/refactorConvertToNamedParameters_methodCallUnion.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_methodCallUnion.ts

@@ -14,9 +14,9 @@
 goTo.select("a", "b");
 // Refactor should not make changes
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class A {
     foo(a: number, b: number) { return a + b; }
 }

tests/cases/fourslash/refactorConvertToNamedParameters_methodCalls.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_methodCalls.ts

@@ -11,9 +11,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     bar({ t, s }: { t: string; s: string; }): string {
         return s + t;