grep should not be an array

Author: rbuckton

.dockerignore

@@ -42,7 +42,6 @@ yarn.lock
 yarn-error.log
 .parallelperf.*
 .failed-tests
-.failed-tests.json
 TEST-results.xml
 package-lock.json
 tests

.gitignore

@@ -83,7 +83,6 @@ tests/cases/user/*/**/*.d.ts
 !tests/cases/user/discord.js/
 tests/baselines/reference/dt
 .failed-tests
-.failed-tests.json
 TEST-results.xml
 package-lock.json
 tests/cases/user/TypeScript-React-Starter/TypeScript-React-Starter

.npmignore

@@ -14,7 +14,6 @@ Jakefile.js
 .eslintignore
 .editorconfig
 .failed-tests
-.failed-tests.json
 .git
 .git/
 .gitattributes

Gulpfile.js

@@ -454,11 +454,11 @@ task("runtests", series(preBuild, preTest, runTests, postTest));
 task("runtests").description = "Runs the tests using the built run.js file.";
 task("runtests").flags = {
     "-t --tests=<regex>": "Pattern for tests to run.",
-    "   --failed": "Runs tests listed in '.failed-tests.json'.",
+    "   --failed": "Runs tests listed in '.failed-tests'.",
     "-r --reporter=<reporter>": "The mocha reporter to use.",
     "-d --debug": "Runs tests in debug mode (NodeJS 6 and earlier)",
     "-i --inspect": "Runs tests in inspector mode (NodeJS 8 and later)",
-    "   --keepFailed": "Keep tests in '.failed-tests.json even if they pass",
+    "   --keepFailed": "Keep tests in '.failed-tests even if they pass",
     "   --light": "Run tests in light mode (fewer verifications, but tests run faster)",
     "   --dirty": "Run tests without first cleaning test output directories",
     "   --stackTraceLimit=<limit>": "Sets the maximum number of stack frames to display. Use 'full' to show all frames.",
@@ -476,7 +476,7 @@ task("runtests-parallel").description = "Runs all the tests in parallel using th
 task("runtests-parallel").flags = {
     "   --no-lint": "disables lint.",
     "   --light": "Run tests in light mode (fewer verifications, but tests run faster).",
-    "   --keepFailed": "Keep tests in '.failed-tests.json' even if they pass.",
+    "   --keepFailed": "Keep tests in .failed-tests even if they pass.",
     "   --dirty": "Run tests without first cleaning test output directories.",
     "   --stackTraceLimit=<limit>": "Sets the maximum number of stack frames to display. Use 'full' to show all frames.",
     "   --workers=<number>": "The number of parallel workers to use.",
@@ -634,9 +634,9 @@ task("watch", series(preBuild, preTest, parallel(watchLib, watchDiagnostics, wat
 task("watch").description = "Watches for changes and rebuilds and runs tests in parallel.";
 task("watch").flags = {
     "-t --tests=<regex>": "Pattern for tests to run. Forces tests to be run in a single worker.",
-    "   --failed": "Runs tests listed in '.failed-tests.json'. Forces tests to be run in a single worker.",
+    "   --failed": "Runs tests listed in '.failed-tests'. Forces tests to be run in a single worker.",
     "-r --reporter=<reporter>": "The mocha reporter to use.",
-    "   --keepFailed": "Keep tests in '.failed-tests.json' even if they pass",
+    "   --keepFailed": "Keep tests in .failed-tests even if they pass",
     "   --light": "Run tests in light mode (fewer verifications, but tests run faster)",
     "   --dirty": "Run tests without first cleaning test output directories",
     "   --stackTraceLimit=<limit>": "Sets the maximum number of stack frames to display. Use 'full' to show all frames.",

scripts/build/tests.js

@@ -84,7 +84,15 @@ async function runConsoleTests(runJs, defaultReporter, runInParallel, watchMode,
             args.push("-g", `"${tests}"`);
         }
         if (failed) {
-            args.push("--config", ".failed-tests.json");
+            const grep = fs.readFileSync(".failed-tests", "utf8")
+                .split(/\r?\n/g)
+                .map(test => test.trim())
+                .filter(test => test.length > 0)
+                .map(regExpEscape)
+                .join("|");
+            const file = path.join(os.tmpdir(), ".failed-tests.json");
+            fs.writeFileSync(file, JSON.stringify({ grep }), "utf8");
+            args.push("--config", file);
         }
         if (colors) {
             args.push("--colors");
@@ -206,3 +214,7 @@ function restoreSavedNodeEnv() {
 function deleteTemporaryProjectOutput() {
     return del(path.join(exports.localBaseline, "projectOutput/"));
 }
+
+function regExpEscape(text) {
+    return text.replace(/[.*+?^${}()|\[\]\\]/g, '\\$&');
+}

scripts/failed-tests.js

@@ -7,7 +7,7 @@ const os = require("os");
 const failingHookRegExp = /^(.*) "(before|after) (all|each)" hook$/;
 
 /**
- * .failed-tests.json reporter
+ * .failed-tests reporter
  *
  * @typedef {Object} ReporterOptions
  * @property {string} [file]
@@ -25,7 +25,7 @@ class FailedTestsReporter extends Mocha.reporters.Base {
         if (!runner) return;
 
         const reporterOptions = this.reporterOptions = options.reporterOptions || {};
-        if (reporterOptions.file === undefined) reporterOptions.file = ".failed-tests.json";
+        if (reporterOptions.file === undefined) reporterOptions.file = ".failed-tests";
         if (reporterOptions.keepFailed === undefined) reporterOptions.keepFailed = false;
         if (reporterOptions.reporter) {
             /** @type {Mocha.ReporterConstructor} */
@@ -70,7 +70,7 @@ class FailedTestsReporter extends Mocha.reporters.Base {
      * @param {(err?: NodeJS.ErrnoException) => void} done
      */
     static writeFailures(file, passes, failures, keepFailed, done) {
-        const failingTests = new Set(readTests());
+        const failingTests = new Set(fs.existsSync(file) ? readTests() : undefined);
         const possiblyPassingSuites = /**@type {Set<string>}*/(new Set());
 
         // Remove tests that are now passing and track suites that are now
@@ -104,8 +104,9 @@ class FailedTestsReporter extends Mocha.reporters.Base {
         if (failingTests.size > 0) {
             const failed = Array
                 .from(failingTests)
-                .sort();
-            fs.writeFile(file, JSON.stringify({ grep: failed }, undefined, "  "), "utf8", done);
+                .sort()
+                .join(os.EOL);
+            fs.writeFile(file, failed, "utf8", done);
         }
         else if (!keepFailed && fs.existsSync(file)) {
             fs.unlink(file, done);
@@ -115,12 +116,10 @@ class FailedTestsReporter extends Mocha.reporters.Base {
         }
 
         function readTests() {
-            try {
-                return JSON.parse(fs.readFileSync(file, "utf8")).grep;
-            }
-            catch {
-                return undefined;
-            }
+            return fs.readFileSync(file, "utf8")
+                .split(/\r?\n/g)
+                .map(line => line.trim())
+                .filter(line => line.length > 0);
         }
     }
 

src/testRunner/parallel/host.ts

@@ -548,7 +548,7 @@ namespace Harness.Parallel.Host {
                 else {
                     failedTestReporter = new FailedTestReporter(replayRunner, {
                         reporterOptions: {
-                            file: path.resolve(".failed-tests.json"),
+                            file: path.resolve(".failed-tests"),
                             keepFailed: Harness.keepFailed // eslint-disable-line @typescript-eslint/no-unnecessary-qualifier
                         }
                     });