fix(45049): fix diagnostic for missing property initializer (#45052)

a-tarasyuk · web-flow · commit 1aac3555f7eb · 2021-07-16T15:10:42.000-07:00
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -1400,7 +1400,7 @@
         "category": "Error",
         "code": 1441
     },
-    "Missing '=' before default property value.": {
+    "Expected '=' for property initializer.": {
         "category": "Error",
         "code": 1442
     },
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -1664,7 +1664,7 @@ namespace ts {
                     parseErrorAtCurrentToken(Diagnostics._0_expected, tokenToString(SyntaxKind.SemicolonToken));
                 }
                 else {
-                    parseErrorAtCurrentToken(Diagnostics.Missing_before_default_property_value);
+                    parseErrorAtCurrentToken(Diagnostics.Expected_for_property_initializer);
                 }
                 return;
             }
diff --git a/tests/baselines/reference/parserErrorRecovery_IncompleteMemberVariable2.errors.txt b/tests/baselines/reference/parserErrorRecovery_IncompleteMemberVariable2.errors.txt
@@ -1,5 +1,5 @@
 tests/cases/conformance/parser/ecmascript5/ErrorRecovery/IncompleteMemberVariables/parserErrorRecovery_IncompleteMemberVariable2.ts(12,20): error TS2304: Cannot find name 'C'.
-tests/cases/conformance/parser/ecmascript5/ErrorRecovery/IncompleteMemberVariables/parserErrorRecovery_IncompleteMemberVariable2.ts(12,22): error TS1442: Missing '=' before default property value.
+tests/cases/conformance/parser/ecmascript5/ErrorRecovery/IncompleteMemberVariables/parserErrorRecovery_IncompleteMemberVariable2.ts(12,22): error TS1442: Expected '=' for property initializer.
 
 
 ==== tests/cases/conformance/parser/ecmascript5/ErrorRecovery/IncompleteMemberVariables/parserErrorRecovery_IncompleteMemberVariable2.ts (2 errors) ====
@@ -18,7 +18,7 @@ tests/cases/conformance/parser/ecmascript5/ErrorRecovery/IncompleteMemberVariabl
                        ~
 !!! error TS2304: Cannot find name 'C'.
                          ~~~~~~~
-!!! error TS1442: Missing '=' before default property value.
+!!! error TS1442: Expected '=' for property initializer.
             // Constructor
             constructor (public x: number, public y: number) { }
     
diff --git a/tests/baselines/reference/privateInstanceMemberAccessibility.errors.txt b/tests/baselines/reference/privateInstanceMemberAccessibility.errors.txt
@@ -3,7 +3,7 @@ tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAcces
 tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(6,15): error TS2340: Only public and protected methods of the base class are accessible via the 'super' keyword.
 tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(8,22): error TS2340: Only public and protected methods of the base class are accessible via the 'super' keyword.
 tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(10,15): error TS2304: Cannot find name 'super'.
-tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(12,12): error TS1442: Missing '=' before default property value.
+tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(12,12): error TS1442: Expected '=' for property initializer.
 
 
 ==== tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts (5 errors) ====
@@ -29,5 +29,5 @@ tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAcces
     
         a: this.foo; // error
                ~
-!!! error TS1442: Missing '=' before default property value.
+!!! error TS1442: Expected '=' for property initializer.
     }

Original file line number	Diff line number	Diff line change
`@@ -1664,7 +1664,7 @@ namespace ts {`
`1664`	`1664`	`parseErrorAtCurrentToken(Diagnostics._0_expected, tokenToString(SyntaxKind.SemicolonToken));`
`1665`	`1665`	`}`
`1666`	`1666`	`else {`
`1667`		`- parseErrorAtCurrentToken(Diagnostics.Missing_before_default_property_value);`
	`1667`	`+ parseErrorAtCurrentToken(Diagnostics.Expected_for_property_initializer);`
`1668`	`1668`	`}`
`1669`	`1669`	`return;`
`1670`	`1670`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAcces`
`3`	`3`	`tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(6,15): error TS2340: Only public and protected methods of the base class are accessible via the 'super' keyword.`
`4`	`4`	`tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(8,22): error TS2340: Only public and protected methods of the base class are accessible via the 'super' keyword.`
`5`	`5`	`tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(10,15): error TS2304: Cannot find name 'super'.`
`6`		`-tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(12,12): error TS1442: Missing '=' before default property value.`
	`6`	`+tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts(12,12): error TS1442: Expected '=' for property initializer.`
`7`	`7`
`8`	`8`
`9`	`9`	`==== tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAccessibility.ts (5 errors) ====`
`@@ -29,5 +29,5 @@ tests/cases/conformance/classes/members/accessibility/privateInstanceMemberAcces`
`29`	`29`
`30`	`30`	`a: this.foo; // error`
`31`	`31`	`~`
`32`		`-!!! error TS1442: Missing '=' before default property value.`
	`32`	`+!!! error TS1442: Expected '=' for property initializer.`
`33`	`33`	`}`