Fix lints

Author: weswigham

src/compiler/wasm/parser.ts

@@ -95,7 +95,7 @@ namespace ts.wasm {
                 case ValueType.f32:
                 case ValueType.f64:
                     cursor.index++;
-                    return byte as ValueType;
+                    return byte;
                 default:
                     Debug.fail(`Unknown value type: ${byte}`); // TODO: Issue diagnostic
             }
@@ -163,7 +163,7 @@ namespace ts.wasm {
                 case ExportKind.Global:
                     cursor.index++;
                     const index = parseUnsignedLEB128u32(cursor);
-                    return { kind: byte as ExportKind, index };
+                    return { kind: byte, index };
                 default:
                     Debug.fail(`Unknown export kind: ${byte}`); // TODO: Issue diagnostic
             }
@@ -217,7 +217,7 @@ namespace ts.wasm {
                     return name;
                 },
                 get bytes() {
-                    this.name;
+                    void this.name; // intializes bytes
                     return bytes;
                 }
             };

src/harness/fakesHosts.ts

@@ -43,7 +43,7 @@ namespace fakes {
 
         public readFile(path: string) {
             try {
-                let content = this.vfs.readFileSync(path, "utf8");
+                const content = this.vfs.readFileSync(path, "utf8");
                 if (content === undefined) {
                     return undefined;
                 }
@@ -56,7 +56,7 @@ namespace fakes {
 
         public readFileBuffer(path: string) {
             try {
-                let content = this.vfs.readFileSync(path);
+                const content = this.vfs.readFileSync(path);
                 if (content === undefined) {
                     return undefined;
                 }

src/server/scriptVersionCache.ts

@@ -371,7 +371,7 @@ namespace ts.server {
         }
 
         getBuffer() {
-            return ts.sys.bufferFrom?.(this.getText(0, this.index.getLength()), "utf8") as Uint8Array; // TODO: Very unsafe, discarding `undefined`
+            return sys.bufferFrom?.(this.getText(0, this.index.getLength()), "utf8") as Uint8Array; // TODO: Very unsafe, discarding `undefined`
         }
 
         getLength() {

src/services/types.ts

@@ -155,7 +155,7 @@ namespace ts {
             }
 
             public getBuffer() {
-                return this.buffer || (ts.sys.bufferFrom?.(this.text, "utf8") as Uint8Array);
+                return this.buffer || (sys.bufferFrom?.(this.text, "utf8") as Uint8Array); // TODO: very unsafe, disreregards `undefined` result
             }
 
             public getLength(): number {