From 1033c7dab0e9e534b0814d88f3bd8592781658e2 Mon Sep 17 00:00:00 2001 From: Andrew McAuliffe Date: Tue, 23 Oct 2018 12:56:00 -0500 Subject: [PATCH] Change setState calls to functional form These are safer forms of setState in this instance since we are computing state based on previous state. --- ExampleProject/components/Hello.tsx | 4 ++-- README.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ExampleProject/components/Hello.tsx b/ExampleProject/components/Hello.tsx index cc01cb5..d871c62 100644 --- a/ExampleProject/components/Hello.tsx +++ b/ExampleProject/components/Hello.tsx @@ -23,8 +23,8 @@ export class Hello extends React.Component { } } - onIncrement = () => this.setState({ enthusiasmLevel: this.state.enthusiasmLevel + 1 }); - onDecrement = () => this.setState({ enthusiasmLevel: this.state.enthusiasmLevel - 1 }); + onIncrement = () => this.setState(prevState => ({ enthusiasmLevel: prevState.enthusiasmLevel + 1 })); + onDecrement = () => this.setState(prevState => ({ enthusiasmLevel: prevState.enthusiasmLevel - 1 })); getExclamationMarks = (numChars: number) => Array(numChars + 1).join("!") render() { diff --git a/README.md b/README.md index a4d9d67..4ff45f9 100644 --- a/README.md +++ b/README.md @@ -190,8 +190,8 @@ export class Hello extends React.Component { } } - onIncrement = () => this.setState({ enthusiasmLevel: this.state.enthusiasmLevel + 1 }); - onDecrement = () => this.setState({ enthusiasmLevel: this.state.enthusiasmLevel - 1 }); + onIncrement = () => this.setState(prevState => ({ enthusiasmLevel: prevState.enthusiasmLevel + 1 })); + onDecrement = () => this.setState(prevState => ({ enthusiasmLevel: prevState.enthusiasmLevel - 1 })); getExclamationMarks = (numChars: number) => Array(numChars + 1).join("!") render() {