Merge pull request #557 from Microsoft/fixes

mhegazy · web-flow · commit f78fe2fa7b11 · 2018-08-02T09:30:55.000-07:00
Fix #549: Add index signature for `HTMLFormElement`
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -6250,6 +6250,7 @@ interface HTMLFormElement extends HTMLElement {
     removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLFormElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
     removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;
     [index: number]: Element;
+    [name: string]: any;
 }
 
 declare var HTMLFormElement: {
diff --git a/inputfiles/overridingTypes.json b/inputfiles/overridingTypes.json
@@ -2297,6 +2297,12 @@
                         }
                     }
                 }
+            },
+            "HTMLFormElement": {
+                "override-index-signatures": [
+                    "[index: number]: Element",
+                    "[name: string]: any"
+                ]
             }
         }
     },

Original file line number	Diff line number	Diff line change
`@@ -6250,6 +6250,7 @@ interface HTMLFormElement extends HTMLElement {`
`6250`	`6250`	`removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLFormElement, ev: HTMLElementEventMap[K]) => any, options?: boolean \| EventListenerOptions): void;`
`6251`	`6251`	`removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean \| EventListenerOptions): void;`
`6252`	`6252`	`[index: number]: Element;`
	`6253`	`+ [name: string]: any;`
`6253`	`6254`	`}`
`6254`	`6255`
`6255`	`6256`	`declare var HTMLFormElement: {`