Merge pull request #367 from arjunyel/getSubscription

mhegazy · web-flow · commit c3856affb2f7 · 2018-02-09T10:38:58.000-08:00
PushManager getSubscription possibly null
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -9114,7 +9114,7 @@ declare var ProgressEvent: {
 };
 
 interface PushManager {
-    getSubscription(): Promise<PushSubscription>;
+    getSubscription(): Promise<PushSubscription | null>;
     permissionState(options?: PushSubscriptionOptionsInit): Promise<PushPermissionState>;
     subscribe(options?: PushSubscriptionOptionsInit): Promise<PushSubscription>;
 }
diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts
@@ -884,7 +884,7 @@ declare var ProgressEvent: {
 };
 
 interface PushManager {
-    getSubscription(): Promise<PushSubscription>;
+    getSubscription(): Promise<PushSubscription | null>;
     permissionState(options?: PushSubscriptionOptionsInit): Promise<PushPermissionState>;
     subscribe(options?: PushSubscriptionOptionsInit): Promise<PushSubscription>;
 }
diff --git a/inputfiles/overridingTypes.json b/inputfiles/overridingTypes.json
@@ -1837,5 +1837,13 @@
         "signatures": [
             "(keyId: any, status: MediaKeyStatus): void"
         ]
+    },
+    {
+        "kind": "method",
+        "name": "getSubscription",
+        "interface": "PushManager",
+        "signatures":[
+            "getSubscription(): Promise<PushSubscription | null>"
+        ]
     }
 ]

Original file line number	Diff line number	Diff line change
`@@ -9114,7 +9114,7 @@ declare var ProgressEvent: {`
`9114`	`9114`	`};`
`9115`	`9115`
`9116`	`9116`	`interface PushManager {`
`9117`		`- getSubscription(): Promise<PushSubscription>;`
	`9117`	`+ getSubscription(): Promise<PushSubscription \| null>;`
`9118`	`9118`	`permissionState(options?: PushSubscriptionOptionsInit): Promise<PushPermissionState>;`
`9119`	`9119`	`subscribe(options?: PushSubscriptionOptionsInit): Promise<PushSubscription>;`
`9120`	`9120`	`}`
Original file line number	Diff line number	Diff line change
`@@ -884,7 +884,7 @@ declare var ProgressEvent: {`
`884`	`884`	`};`
`885`	`885`
`886`	`886`	`interface PushManager {`
`887`		`- getSubscription(): Promise<PushSubscription>;`
	`887`	`+ getSubscription(): Promise<PushSubscription \| null>;`
`888`	`888`	`permissionState(options?: PushSubscriptionOptionsInit): Promise<PushPermissionState>;`
`889`	`889`	`subscribe(options?: PushSubscriptionOptionsInit): Promise<PushSubscription>;`
`890`	`890`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1837,5 +1837,13 @@`
`1837`	`1837`	`"signatures": [`
`1838`	`1838`	`"(keyId: any, status: MediaKeyStatus): void"`
`1839`	`1839`	`]`
	`1840`	`+ },`
	`1841`	`+ {`
	`1842`	`+ "kind": "method",`
	`1843`	`+ "name": "getSubscription",`
	`1844`	`+ "interface": "PushManager",`
	`1845`	`+ "signatures":[`
	`1846`	`+ "getSubscription(): Promise<PushSubscription \| null>"`
	`1847`	`+ ]`
`1840`	`1848`	`}`
`1841`	`1849`	`]`