Skip to content

Commit 11aec79

Browse files
committed
Fix merging
1 parent 04d7dce commit 11aec79

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/emitter.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ export function emitWebIDl(webidl: Browser.WebIdl, flavor: Flavor) {
607607
}
608608
const requiredModifier = !p.required || p.required === "1" ? "" : "?";
609609
pType = p.nullable ? makeNullable(pType) : pType;
610-
const readOnlyModifier = p["read-only"] && prefix === "" ? "readonly " : "";
610+
const readOnlyModifier = p["read-only"] === 1 && prefix === "" ? "readonly " : "";
611611
printLine(`${prefix}${readOnlyModifier}${p.name}${requiredModifier}: ${pType};`);
612612
}
613613
}
@@ -801,9 +801,9 @@ export function emitWebIDl(webidl: Browser.WebIdl, flavor: Flavor) {
801801

802802
printer.printLine(`interface ${processInterfaceType(i, processedIName)}`);
803803

804-
const finalExtends = [i.extends || "Object"].concat(i.implements || [])
804+
const finalExtends = distinct([i.extends || "Object"].concat(i.implements || [])
805805
.filter(i => i !== "Object")
806-
.map(processIName);
806+
.map(processIName));
807807

808808
if (finalExtends && finalExtends.length) {
809809
printer.print(` extends ${finalExtends.join(", ")}`);

src/helpers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function filterProperties<T>(obj: Record<string, T>, fn: (o: T) => boolea
2828

2929
export function merge<T>(src: T, target: T): T {
3030
if (typeof src !== "object" || typeof target !== "object") {
31-
return src;
31+
return target;
3232
}
3333
for (const k in target) {
3434
if (Object.getOwnPropertyDescriptor(target, k)) {
@@ -42,7 +42,7 @@ export function merge<T>(src: T, target: T): T {
4242
if (Array.isArray(srcProp) !== Array.isArray(targetProp)) {
4343
throw new Error("Mismatch on property: " + k + JSON.stringify(targetProp));
4444
}
45-
merge(src[k], target[k]);
45+
src[k] = merge(src[k], target[k]);
4646
}
4747
}
4848
else {

0 commit comments

Comments
 (0)