Skip to content

Commit 1e05ade

Browse files
committed
Improve brave auto-configuration tests
See spring-projectsgh-30156
1 parent b74554f commit 1e05ade

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/BraveAutoConfigurationTests.java

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616

1717
package org.springframework.boot.actuate.autoconfigure.tracing;
1818

19+
import brave.Tracing;
1920
import io.micrometer.tracing.brave.bridge.BraveTracer;
2021
import org.junit.jupiter.api.Test;
2122

2223
import org.springframework.boot.autoconfigure.AutoConfigurations;
24+
import org.springframework.boot.test.context.FilteredClassLoader;
2325
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2426

2527
import static org.assertj.core.api.Assertions.assertThat;
@@ -32,12 +34,23 @@
3234
class BraveAutoConfigurationTests {
3335

3436
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
35-
.withConfiguration(AutoConfigurations.of(MicrometerTracingAutoConfiguration.class,
36-
ZipkinAutoConfiguration.class, BraveAutoConfiguration.class));
37+
.withConfiguration(AutoConfigurations.of(BraveAutoConfiguration.class));
3738

3839
@Test
39-
void hasBraveTracer() {
40+
void shouldNotFailIfBraveIsMissing() {
41+
this.contextRunner.withClassLoader(new FilteredClassLoader("brave"))
42+
.run((context) -> assertThat(context).doesNotHaveBean(Tracing.class));
43+
}
44+
45+
@Test
46+
void shouldHaveBraveTracer() {
4047
this.contextRunner.run((context) -> assertThat(context).hasSingleBean(BraveTracer.class));
4148
}
4249

50+
@Test
51+
void shouldNotFailIfMicrometerIsMissing() {
52+
this.contextRunner.withClassLoader(new FilteredClassLoader("io.micrometer"))
53+
.run((context) -> assertThat(context).doesNotHaveBean(BraveTracer.class));
54+
}
55+
4356
}

0 commit comments

Comments
 (0)