Skip to content

Commit d3076c9

Browse files
yeahdongcnmglambda
authored andcommitted
musa: bump MUSA SDK version to rc3.1.1 (ggml-org#11822)
* musa: Update MUSA SDK version to rc3.1.1 Signed-off-by: Xiaodong Ye <[email protected]> * musa: Remove workaround in PR ggml-org#10042 Signed-off-by: Xiaodong Ye <[email protected]> --------- Signed-off-by: Xiaodong Ye <[email protected]>
1 parent baaa5c5 commit d3076c9

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

.devops/musa.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ARG UBUNTU_VERSION=22.04
22
# This needs to generally match the container host's environment.
3-
ARG MUSA_VERSION=rc3.1.0
3+
ARG MUSA_VERSION=rc3.1.1
44
# Target the MUSA build image
55
ARG BASE_MUSA_DEV_CONTAINER=mthreads/musa:${MUSA_VERSION}-devel-ubuntu${UBUNTU_VERSION}
66

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ jobs:
443443
444444
ubuntu-22-cmake-musa:
445445
runs-on: ubuntu-22.04
446-
container: mthreads/musa:rc3.1.0-devel-ubuntu22.04
446+
container: mthreads/musa:rc3.1.1-devel-ubuntu22.04
447447

448448
steps:
449449
- name: Clone

docs/docker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ You may want to pass in some different `ARGS`, depending on the MUSA environment
104104

105105
The defaults are:
106106

107-
- `MUSA_VERSION` set to `rc3.1.0`
107+
- `MUSA_VERSION` set to `rc3.1.1`
108108

109109
The resulting images, are essentially the same as the non-MUSA images:
110110

ggml/src/ggml-cuda/ggml-cuda.cu

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1480,12 +1480,7 @@ static void ggml_cuda_op_mul_mat(
14801480
const size_t nbytes_data = ggml_nbytes(src0);
14811481
const size_t nbytes_padding = ggml_row_size(src0->type, MATRIX_ROW_PADDING - ne00 % MATRIX_ROW_PADDING);
14821482
dev[id].src0_dd = dev[id].src0_dd_alloc.alloc(ctx.pool(id), nbytes_data + nbytes_padding);
1483-
// TODO: remove this for MUSA once the Guilty Lockup issue is resolved
1484-
#ifndef GGML_USE_MUSA
14851483
CUDA_CHECK(cudaMemsetAsync(dev[id].src0_dd, 0, nbytes_data + nbytes_padding, stream));
1486-
#else // GGML_USE_MUSA
1487-
CUDA_CHECK(cudaMemsetAsync(dev[id].src0_dd + nbytes_data, 0, nbytes_padding, stream));
1488-
#endif // !GGML_USE_MUSA
14891484
}
14901485

14911486
// If src0 is on a temporary compute buffer (partial offloading) there may be some padding that needs to be cleared:

0 commit comments

Comments
 (0)