add feature for clients that do not implement send #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
approved these changes
May 2, 2024
Contributor
irevoire
left a comment
irevoire
left a comment
There was a problem hiding this comment.
Hey @ezegrosfeld, thanks a lot for your contribution.
It’s exactly what I was looking for!
bors merge
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #577
What does this PR do?
Some clients do not have Send compatible futures. To fix this I propose adding a feature disabled by default to support this kind of clients like acw, Send should be supported by default.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!