Skip to content

Commit 2a9a13d

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Reduce visibility of methods in FabricUIManager (facebook#48824)
Summary: Pull Request resolved: facebook#48824 Reduce visibility of methods in FabricUIManager and fix lint warnings changelog: [Android][Breaking] Reduce visibility of FabricUIManager.setBinding() method, unused outside of react native Reviewed By: philIip Differential Revision: D68459708 fbshipit-source-id: 59081b9a87607b1d35c3fc88bb16e5980cfbd721
1 parent 10f4772 commit 2a9a13d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2622,7 +2622,6 @@ public class com/facebook/react/fabric/FabricUIManager : com/facebook/react/brid
26222622
public fun resolveView (I)Landroid/view/View;
26232623
public fun sendAccessibilityEvent (II)V
26242624
public fun sendAccessibilityEventFromJS (IILjava/lang/String;)V
2625-
public fun setBinding (Lcom/facebook/react/fabric/FabricUIManagerBinding;)V
26262625
public fun setJSResponder (IIIZ)V
26272626
public fun startSurface (Landroid/view/View;Ljava/lang/String;Lcom/facebook/react/bridge/WritableMap;II)I
26282627
public fun startSurface (Lcom/facebook/react/interfaces/fabric/SurfaceHandler;Landroid/content/Context;Landroid/view/View;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,7 @@ private long measureMapBuffer(
609609
* padding used by RN Android TextInput.
610610
* @return if theme data is available in the output parameters.
611611
*/
612+
@SuppressWarnings("unused")
612613
public boolean getThemeData(int surfaceId, float[] defaultTextInputPadding) {
613614
SurfaceMountingManager surfaceMountingManager = mMountingManager.getSurfaceManager(surfaceId);
614615
Context context = surfaceMountingManager != null ? surfaceMountingManager.getContext() : null;
@@ -868,7 +869,7 @@ public void experimental_prefetchResource(
868869
mReactApplicationContext, componentName, surfaceId, reactTag, params);
869870
}
870871

871-
public void setBinding(FabricUIManagerBinding binding) {
872+
void setBinding(FabricUIManagerBinding binding) {
872873
mBinding = binding;
873874
}
874875

@@ -985,7 +986,7 @@ public void receiveEvent(
985986
EventEmitterWrapper eventEmitter = mMountingManager.getEventEmitter(surfaceId, reactTag);
986987
if (eventEmitter == null) {
987988
if (mMountingManager.getViewExists(reactTag)) {
988-
// The view is preallocated and created. However, it hasn't been mounted yet. We will have
989+
// The view is pre-allocated and created. However, it hasn't been mounted yet. We will have
989990
// access to the event emitter later when the view is mounted. For now just save the event
990991
// in the view state and trigger it later.
991992
mMountingManager.enqueuePendingEvent(

0 commit comments

Comments
 (0)