Skip to content

Conversation

@multiplemonomials
Copy link
Collaborator

Summary of changes

This PR reactivates the tests of all the block devices under storage/blockdevices, Looking at these tests initially I had thought that they were just for the "software" block devices like SlicingBlockDevice, but actually no: the "general" block device test actually tests all the hardware block device drivers if they exist on the current target.

I set up the build system for these tests so that they should now be able to run again.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

I ran the new tests on Arduino Giga (which has a QSPIF block device) and they all passed.


Reviewers


@multiplemonomials
Copy link
Collaborator Author

@JohnK1987 responded to your comment

@multiplemonomials multiplemonomials merged commit 04db467 into master Apr 25, 2024
@multiplemonomials multiplemonomials deleted the dev/reactivate-blockdevice-tests branch April 25, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants