Pass in custom mention menu component #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanyiu
commented
Jul 12, 2018
ryanyiu
commented
- Custom mention menu component can act as a replacement for the mention menu (in the cases where the mention menu might not work)
- Accepts same props as Mention Menu in addition to the closeMenu function of MentionWrapper to allow for more control over when the custom mention menu might close.
- Also allowed for classnames and containerStyles to be passed in for the surrounding div and text area for more custom styling
and fix so menu doesnt go off right side of screen or bottom
- Updated react and react-dom dependencies to the current versions - Updated package.json to include the current versions (also added peer dependencies to dependencies because there was an issue of yarn build not adding the required node_modules properly)
Browser and mobile @mentions will be different now, so this should be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.