This repository was archived by the owner on Nov 30, 2020. It is now read-only.
feat(text-field): optimize instantiation process #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(text-field-character-counter): avoid props being overwrite unexpectedly fix(text-field): lint docs(text-field): simplify
…dd provide/inject for better instantiation
Following component will use instance created by parent, if their parent is `m-text-field`: `m-floating-label`, `m-line-ripple`, `m-notched-outline` and `m-text-field-icon`
feat(text-field): add helper line component BREAKING CHANGE: now helper text and character counter should be placed in the helper line component
# Conflicts: # package.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(text-field-character-counter): avoid props being overwritten unexpectedly
fix(text-field): make props like outlined, fullWidth more reactive; add provide/inject for better instantiation
feat(text-field): add helper line component
fix: text field helper text component doesn't instantiate correctly
BREAKING CHANGE: now helper text and character counter should be placed in the helper line component
feat(text-field): add slot
characterCounterfor textareatest(text-field): update snapshots and lint files
#323 is also explained in the updated readme.