Location streaming tweaks #3622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switched from `m.beacon.*` state event to `m.becon` reference relationship to original `m.beacon_info.*` - changed `beacon_info` created to `m.ts` - renamed `lifetime` to `timeout` - added `m.asset` `type`
ara4n
reviewed
Jan 5, 2022
ara4n
reviewed
Jan 5, 2022
ara4n
reviewed
Jan 5, 2022
ara4n
reviewed
Jan 5, 2022
Member
|
lgtm other than clarifying how asset identifiers works in the context of the beacon_info state event type. thanks! |
ara4n
approved these changes
Jan 12, 2022
Member
ara4n
left a comment
ara4n
left a comment
There was a problem hiding this comment.
lgtm! thanks for incorporating the feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tweaks following initial implementation:
m.beacon.*state event tom.beconreference relationship to originalm.beacon_info.*as a better way to store streams of related databeacon_infocreatedtom.tsto avoid introducing a new conceptlifetimetotimeoutas a better way of defining how long since the last event until we consider the beacon inactivem.assettypeto be able to distinguish between users and other types of assets being trackedPreview: https://pr3622--matrix-org-previews.netlify.app