Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Use a consistent alignment for all text items in a list #8276

Merged
merged 5 commits into from
Apr 11, 2022
Merged

Use a consistent alignment for all text items in a list #8276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a09b95a
Use a consistent alignment for all text items in a list
luixxiul Apr 10, 2022
5d5b4c1
Use a consistent alignment for all text items in a list
luixxiul Apr 10, 2022
a8cfa02
Use a consistent alignment for all text items in a list
luixxiul Apr 10, 2022
c6fb80a
lint
luixxiul Apr 10, 2022
0dacf7a
Merge branch 'develop' into rtl-2
t3chguy Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/views/messages/DisambiguatedProfile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ export default class DisambiguatedProfile extends React.Component<IProps> {
});

return (
<div className="mx_DisambiguatedProfile" dir="auto" onClick={onClick}>
<span className={displayNameClasses}>
<div className="mx_DisambiguatedProfile" onClick={onClick}>
<span className={displayNameClasses} dir="auto">
{ rawDisplayName }
</span>
{ mxidElement }
Expand Down
2 changes: 1 addition & 1 deletion src/components/views/right_panel/UserInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,7 +1444,7 @@ const UserInfoHeader: React.FC<{
<div>
<h2>
{ e2eIcon }
<span title={displayName} aria-label={displayName}>
<span title={displayName} aria-label={displayName} dir="auto">
{ displayName }
</span>
</h2>
Expand Down
6 changes: 3 additions & 3 deletions src/components/views/rooms/EntityTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export default class EntityTile extends React.PureComponent<IProps, IState> {
}
nameEl = (
<div className="mx_EntityTile_details">
<div className="mx_EntityTile_name" dir="auto">
<div className="mx_EntityTile_name">
Copy link
Contributor Author

@luixxiul luixxiul Apr 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying the direction on this level forces child elements to be moved to the right side even on the LTR layout, if the user name includes characters in a RTL language. DisambiguatedProfile should take care of the direction.

{ name }
</div>
{ presenceLabel }
Expand All @@ -142,15 +142,15 @@ export default class EntityTile extends React.PureComponent<IProps, IState> {
} else if (this.props.subtextLabel) {
nameEl = (
<div className="mx_EntityTile_details">
<div className="mx_EntityTile_name" dir="auto">
<div className="mx_EntityTile_name">
{ name }
</div>
<span className="mx_EntityTile_subtext">{ this.props.subtextLabel }</span>
</div>
);
} else {
nameEl = (
<div className="mx_EntityTile_name" dir="auto">{ name }</div>
<div className="mx_EntityTile_name">{ name }</div>
);
}

Expand Down
6 changes: 4 additions & 2 deletions src/components/views/rooms/RoomTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,8 +683,10 @@ export default class RoomTile extends React.PureComponent<IProps, IState> {

const titleContainer = this.props.isMinimized ? null : (
<div className="mx_RoomTile_titleContainer">
<div title={name} className={titleClasses} tabIndex={-1} dir="auto">
{ name }
<div title={name} className={titleClasses} tabIndex={-1}>
<span dir="auto">
{ name }
</span>
</div>
{ subtitle }
</div>
Expand Down