Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Mar 24, 2022

Closes element-hq/element-web#21553

after.mp4

Signed-off-by: Suguru Hirahara [email protected]


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Preview: https://pr8146--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@luixxiul luixxiul requested a review from a team as a code owner March 24, 2022 15:18
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@t3chguy t3chguy enabled auto-merge (squash) March 24, 2022 15:20
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #8146 (faa7083) into develop (981b44c) will not change coverage.
The diff coverage is n/a.

❗ Current head faa7083 differs from pull request most recent head 6e8866f. Consider uploading reports for the commit 6e8866f to get more accurate results

@@           Coverage Diff            @@
##           develop    #8146   +/-   ##
========================================
  Coverage    28.38%   28.38%           
========================================
  Files          847      847           
  Lines        49486    49486           
  Branches     12546    12546           
========================================
  Hits         14046    14046           
  Misses       35440    35440           

@turt2live
Copy link
Member

github broke on this - manually merging

@turt2live turt2live disabled auto-merge March 24, 2022 19:51
@turt2live turt2live merged commit f229ad6 into matrix-org:develop Mar 24, 2022
@luixxiul luixxiul deleted the NewRoomIntro branch March 24, 2022 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buttons gap on NewRoom intro on a room in Space

3 participants