This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Live location share - set time limit #8082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 18, 2022 12:42
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #8082 +/- ##
===========================================
+ Coverage 26.66% 26.71% +0.05%
===========================================
Files 870 871 +1
Lines 52166 52196 +30
Branches 13217 13224 +7
===========================================
+ Hits 13910 13946 +36
+ Misses 38256 38250 -6
|
turt2live
approved these changes
Mar 18, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
otherwise looks good - thanks!
src/DateUtils.ts
Outdated
| const MINUTE_MS = 60000; | ||
| const HOUR_MS = MINUTE_MS * 60; | ||
| const DAY_MS = HOUR_MS * 24; | ||
| export const formatDuration = (durationMs: number): string => { |
Member
There was a problem hiding this comment.
can we make this a regular function to match the code style in the area?
Member
|
does this also need a design review? |
added 3 commits
March 18, 2022 17:56
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Contributor
Author
|
Merging without design review to unblock as Gaelle is away. This is behind a labs flag and under active development so design review will be done in upcoming prs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figma: https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=365%3A144459
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://pr8082--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.