From d151f691401482d9b0b9acf7193be7809fd44844 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon=20Brandner?= Date: Mon, 15 Nov 2021 19:57:56 +0100 Subject: [PATCH 1/3] Make text non-selectable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Šimon Brandner --- res/css/views/voip/_CallView.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/res/css/views/voip/_CallView.scss b/res/css/views/voip/_CallView.scss index 088486bdf6c..c41361c90dc 100644 --- a/res/css/views/voip/_CallView.scss +++ b/res/css/views/voip/_CallView.scss @@ -126,6 +126,8 @@ limitations under the License. padding-top: 20px; padding-bottom: 15px; color: $accent-fg-color; + user-select: none; + .mx_AccessibleButton_hasKind { padding: 0px; font-weight: bold; From cea8132a10ddb902e8b6964e9008f14f2b608d06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon=20Brandner?= Date: Mon, 15 Nov 2021 20:00:29 +0100 Subject: [PATCH 2/3] Make double-clicking the PiP take you to the call room MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Šimon Brandner --- src/components/views/voip/CallPreview.tsx | 8 ++++++++ src/components/views/voip/PictureInPictureDragger.tsx | 2 ++ 2 files changed, 10 insertions(+) diff --git a/src/components/views/voip/CallPreview.tsx b/src/components/views/voip/CallPreview.tsx index 266c34083eb..e34266616ea 100644 --- a/src/components/views/voip/CallPreview.tsx +++ b/src/components/views/voip/CallPreview.tsx @@ -178,6 +178,13 @@ export default class CallPreview extends React.Component { }); }; + private onDoubleClick = (): void => { + dis.dispatch({ + action: "view_room", + room_id: this.state.primaryCall.roomId, + }); + }; + public render() { const pipMode = true; if (this.state.primaryCall) { @@ -185,6 +192,7 @@ export default class CallPreview extends React.Component { { ({ onStartMoving, onResize }) => React.ReactNode; draggable: boolean; + onDoubleClick?: () => void; } interface IState { @@ -216,6 +217,7 @@ export default class PictureInPictureDragger extends React.Component <> { this.props.children({ From 9575e99b8810f03af576e05147d12d9e1db2ffff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon=20Brandner?= Date: Mon, 15 Nov 2021 20:05:39 +0100 Subject: [PATCH 3/3] Don't go to room on avatar click MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Šimon Brandner --- .../views/voip/CallView/CallViewHeader.tsx | 22 +++++-------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/src/components/views/voip/CallView/CallViewHeader.tsx b/src/components/views/voip/CallView/CallViewHeader.tsx index d9a49e50102..bbdf1fbae60 100644 --- a/src/components/views/voip/CallView/CallViewHeader.tsx +++ b/src/components/views/voip/CallView/CallViewHeader.tsx @@ -19,7 +19,6 @@ import { Room } from 'matrix-js-sdk/src/models/room'; import React from 'react'; import { _t, _td } from '../../../../languageHandler'; import RoomAvatar from '../../avatars/RoomAvatar'; -import AccessibleButton from '../../elements/AccessibleButton'; import dis from '../../../../dispatcher/dispatcher'; import classNames from 'classnames'; import AccessibleTooltipButton from '../../elements/AccessibleTooltipButton'; @@ -36,13 +35,6 @@ interface CallViewHeaderProps { onPipMouseDown: (event: React.MouseEvent) => void; } -const onRoomAvatarClick = (roomId: string) => { - dis.dispatch({ - action: 'view_room', - room_id: roomId, - }); -}; - const onFullscreenClick = () => { dis.dispatch({ action: 'video_fullscreen', @@ -76,12 +68,10 @@ const CallViewHeaderControls: React.FC = ({ pipMode = false, }; const SecondaryCallInfo: React.FC<{ callRoom: Room }> = ({ callRoom }) => { return - onRoomAvatarClick(callRoom.roomId)}> - - - { _t("%(name)s on hold", { name: callRoom.name }) } - - + + + { _t("%(name)s on hold", { name: callRoom.name }) } + ; }; @@ -117,9 +107,7 @@ const CallViewHeader: React.FC = ({ className="mx_CallViewHeader" onMouseDown={onPipMouseDown} > - onRoomAvatarClick(roomId)}> - - +
{ callRoomName }