Switch to using stable values for Threads #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Mar 10, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2228 +/- ##
===========================================
+ Coverage 57.68% 57.82% +0.13%
===========================================
Files 90 90
Lines 16287 16300 +13
Branches 3752 3756 +4
===========================================
+ Hits 9395 9425 +30
+ Misses 6892 6875 -17
|
t3chguy
approved these changes
Mar 10, 2022
| return this.stable; | ||
| } | ||
| return this.unstable; | ||
| } |
Member
There was a problem hiding this comment.
maybe we should also override .altName to return the same as .name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to element-hq/element-web#21215
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.