Skip to content

Group call improvements #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Group call improvements #2000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/webrtc/groupCall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export class GroupCall extends EventEmitter {

this.addParticipant(this.room.getMember(this.client.getUserId()));

this.sendMemberStateEvent();
const sendMemberStateEventPromise = this.sendMemberStateEvent();

this.activeSpeaker = null;

Expand All @@ -262,9 +262,14 @@ export class GroupCall extends EventEmitter {

logger.log("Processing initial members");

for (const stateEvent of memberStateEvents) {
this.onMemberStateChanged(stateEvent);
}
// This avoids a race condition where the other side would first receive
// the to-device messages and only then the member state event which
// would result in the call being ignored
sendMemberStateEventPromise.then(() => {
for (const stateEvent of memberStateEvents) {
this.onMemberStateChanged(stateEvent);
}
});

this.client.on("Call.incoming", this.onIncomingCall);

Expand Down