massive-com
diff --git a/‎.github/workflows/closed-issue-message.yml‎
Lines changed: 2 additions & 4 deletions b/‎.github/workflows/closed-issue-message.yml‎
Lines changed: 2 additions & 4 deletions
diff --git a/‎.github/workflows/stale_issue.yml‎
Lines changed: 2 additions & 2 deletions b/‎.github/workflows/stale_issue.yml‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎CHANGELOG.md‎
Lines changed: 1228 additions & 0 deletions b/‎CHANGELOG.md‎
Lines changed: 1228 additions & 0 deletions
diff --git a/‎Makefile‎
Lines changed: 7 additions & 5 deletions b/‎Makefile‎
Lines changed: 7 additions & 5 deletions
diff --git a/‎aws/config.go‎
Lines changed: 13 additions & 2 deletions b/‎aws/config.go‎
Lines changed: 13 additions & 2 deletions
diff --git a/‎aws/go_module_metadata.go‎
Lines changed: 1 addition & 1 deletion b/‎aws/go_module_metadata.go‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎aws/middleware/metadata.go‎
Lines changed: 13 additions & 1 deletion b/‎aws/middleware/metadata.go‎
Lines changed: 13 additions & 1 deletion
diff --git a/‎aws/middleware/private/metrics/emf/emf.go‎
Lines changed: 90 additions & 0 deletions b/‎aws/middleware/private/metrics/emf/emf.go‎
Lines changed: 90 additions & 0 deletions
diff --git a/‎aws/middleware/private/metrics/emf/emf_test.go‎
Lines changed: 145 additions & 0 deletions b/‎aws/middleware/private/metrics/emf/emf_test.go‎
Lines changed: 145 additions & 0 deletions
@@ -11,7 +11,5 @@ jobs:
             # These inputs are both required
             repo-token: "${{ secrets.GITHUB_TOKEN }}"
             message: |
-                     ### ⚠️COMMENT VISIBILITY WARNING⚠️
-                     Comments on closed issues are hard for our team to see.
-                     If you need more assistance, please either tag a team member or open a new issue that references this one.
-                     If you wish to keep having a conversation with other community members under this issue feel free to do so.
+              This issue is now closed. Comments on closed issues are hard for our team to see. 
+              If you need more assistance, please open a new issue that references this one. 
@@ -30,8 +30,8 @@ jobs:
         closed-for-staleness-label: closed-for-staleness
 
         # Issue timing
-        days-before-stale: 2
-        days-before-close: 5
+        days-before-stale: 10
+        days-before-close: 4
         days-before-ancient: 36500
 
         # If you don't want to mark a issue as being ancient based on a
 
@@ -4,6 +4,7 @@ LINT_IGNORE_S3MANAGER_INPUT='feature/s3/manager/upload.go:.+struct field SSEKMSK
 # Names of these are tied to endpoint rules and they're internal so ignore them
 LINT_IGNORE_AWSRULESFN_ARN='internal/endpoints/awsrulesfn/arn.go'
 LINT_IGNORE_AWSRULESFN_PARTITION='internal/endpoints/awsrulesfn/partition.go'
+LINT_IGNORE_PRIVATE_METRICS='aws/middleware/private/metrics'
 
 UNIT_TEST_TAGS=
 BUILD_TAGS=-tags "example,codegen,integration,ec2env,perftest"
@@ -254,7 +255,7 @@ unit-race-modules-%:
 		&& go run . -p $(subst _,/,$(subst unit-race-modules-,,$@)) ${EACHMODULE_FLAGS} \
 		"go vet ${BUILD_TAGS} --all ./..." \
 		"go test ${BUILD_TAGS} ${RUN_NONE} ./..." \
-		"go test -timeout=1m ${UNIT_TEST_TAGS} -race -cpu=4 ./..."
+		"go test -timeout=2m ${UNIT_TEST_TAGS} -race -cpu=4 ./..."
 
 unit-modules-%:
 	@# unit command that uses the pattern to define the root path that the
@@ -266,7 +267,7 @@ unit-modules-%:
 		&& go run . -p $(subst _,/,$(subst unit-modules-,,$@)) ${EACHMODULE_FLAGS} \
 		"go vet ${BUILD_TAGS} --all ./..." \
 		"go test ${BUILD_TAGS} ${RUN_NONE} ./..." \
-		"go test -timeout=1m ${UNIT_TEST_TAGS} ./..."
+		"go test -timeout=2m ${UNIT_TEST_TAGS} ./..."
 
 build: build-modules-.
 
@@ -302,7 +303,7 @@ test-race-modules-%:
 	@# e.g. test-race-modules-internal_protocoltest
 	cd ./internal/repotools/cmd/eachmodule \
 		&& go run . -p $(subst _,/,$(subst test-race-modules-,,$@)) ${EACHMODULE_FLAGS} \
-		"go test -timeout=1m ${UNIT_TEST_TAGS} -race -cpu=4 ./..."
+		"go test -timeout=2m ${UNIT_TEST_TAGS} -race -cpu=4 ./..."
 
 test-modules-%:
 	@# Test command that uses the pattern to define the root path that the
@@ -312,7 +313,7 @@ test-modules-%:
 	@# e.g. test-modules-internal_protocoltest
 	cd ./internal/repotools/cmd/eachmodule \
 		&& go run . -p $(subst _,/,$(subst test-modules-,,$@)) ${EACHMODULE_FLAGS} \
-		"go test -timeout=1m ${UNIT_TEST_TAGS} ./..."
+		"go test -timeout=2m ${UNIT_TEST_TAGS} ./..."
 
 cachedep: cachedep-modules-.
 
@@ -472,7 +473,8 @@ lint:
 	-e ${LINT_IGNORE_S3MANAGER_INPUT} \
 	-e ${LINTIGNORESINGLEFIGHT} \
 	-e ${LINT_IGNORE_AWSRULESFN_ARN} \
-	-e ${LINT_IGNORE_AWSRULESFN_PARTITION}`; \
+	-e ${LINT_IGNORE_AWSRULESFN_PARTITION} \
+	-e ${LINT_IGNORE_PRIVATE_METRICS}`; \
 	echo "$$dolint"; \
 	if [ "$$dolint" != "" ]; then exit 1; fi
 
 
@@ -150,6 +150,18 @@ type Config struct {
 	// BaseEndpoint is an intermediary transfer location to a service specific
 	// BaseEndpoint on a service's Options.
 	BaseEndpoint *string
+
+	// DisableRequestCompression toggles if an operation request could be
+	// compressed or not. Will be set to false by default. This variable is sourced from
+	// environment variable AWS_DISABLE_REQUEST_COMPRESSION or the shared config profile attribute
+	// disable_request_compression
+	DisableRequestCompression bool
+
+	// RequestMinCompressSizeBytes sets the inclusive min bytes of a request body that could be
+	// compressed. Will be set to 10240 by default and must be within 0 and 10485760 bytes inclusively.
+	// This variable is sourced from environment variable AWS_REQUEST_MIN_COMPRESSION_SIZE_BYTES or
+	// the shared config profile attribute request_min_compression_size_bytes
+	RequestMinCompressSizeBytes int64
 }
 
 // NewConfig returns a new Config pointer that can be chained with builder
@@ -158,8 +170,7 @@ func NewConfig() *Config {
 	return &Config{}
 }
 
-// Copy will return a shallow copy of the Config object. If any additional
-// configurations are provided they will be merged into the new config returned.
+// Copy will return a shallow copy of the Config object.
 func (c Config) Copy() Config {
 	cp := c
 	return cp
 
@@ -65,6 +65,9 @@ func GetServiceID(ctx context.Context) (v string) {
 //
 // Scoped to stack values. Use github.com/aws/smithy-go/middleware#ClearStackValues
 // to clear all stack values.
+//
+// Deprecated: This value is unstable. The resolved signing name is available
+// in the signer properties object passed to the signer.
 func GetSigningName(ctx context.Context) (v string) {
 	v, _ = middleware.GetStackValue(ctx, signingNameKey{}).(string)
 	return v
@@ -74,6 +77,9 @@ func GetSigningName(ctx context.Context) (v string) {
 //
 // Scoped to stack values. Use github.com/aws/smithy-go/middleware#ClearStackValues
 // to clear all stack values.
+//
+// Deprecated: This value is unstable. The resolved signing region is available
+// in the signer properties object passed to the signer.
 func GetSigningRegion(ctx context.Context) (v string) {
 	v, _ = middleware.GetStackValue(ctx, signingRegionKey{}).(string)
 	return v
@@ -125,10 +131,13 @@ func SetRequiresLegacyEndpoints(ctx context.Context, value bool) context.Context
 	return middleware.WithStackValue(ctx, requiresLegacyEndpointsKey{}, value)
 }
 
-// SetSigningName set or modifies the signing name on the context.
+// SetSigningName set or modifies the sigv4 or sigv4a signing name on the context.
 //
 // Scoped to stack values. Use github.com/aws/smithy-go/middleware#ClearStackValues
 // to clear all stack values.
+//
+// Deprecated: This value is unstable. Use WithSigV4SigningName client option
+// funcs instead.
 func SetSigningName(ctx context.Context, value string) context.Context {
 	return middleware.WithStackValue(ctx, signingNameKey{}, value)
 }
@@ -137,6 +146,9 @@ func SetSigningName(ctx context.Context, value string) context.Context {
 //
 // Scoped to stack values. Use github.com/aws/smithy-go/middleware#ClearStackValues
 // to clear all stack values.
+//
+// Deprecated: This value is unstable. Use WithSigV4SigningRegion client option
+// funcs instead.
 func SetSigningRegion(ctx context.Context, value string) context.Context {
 	return middleware.WithStackValue(ctx, signingRegionKey{}, value)
 }
 
@@ -0,0 +1,90 @@
+// Package emf implements an EMF metrics publisher.
+//
+// This package is designated as private and is intended for use only by the
+// smithy client runtime. The exported API therein is not considered stable and
+// is subject to breaking changes without notice.
+package emf
+
+import (
+	"github.com/aws/aws-sdk-go-v2/aws/middleware/private/metrics"
+	"github.com/aws/aws-sdk-go-v2/internal/sdk"
+)
+
+const (
+	emfIdentifier        = "_aws"
+	timestampKey         = "Timestamp"
+	cloudWatchMetricsKey = "CloudWatchMetrics"
+	namespaceKey         = "Namespace"
+	dimensionsKey        = "Dimensions"
+	metricsKey           = "Metrics"
+)
+
+// Entry represents a log entry in the EMF format.
+type Entry struct {
+	namespace  string
+	serializer metrics.Serializer
+	metrics    []metric
+	dimensions [][]string
+	fields     map[string]interface{}
+}
+
+type metric struct {
+	Name string
+}
+
+// NewEntry creates a new Entry with the specified namespace and serializer.
+func NewEntry(namespace string, serializer metrics.Serializer) Entry {
+	return Entry{
+		namespace:  namespace,
+		serializer: serializer,
+		metrics:    []metric{},
+		dimensions: [][]string{{}},
+		fields:     map[string]interface{}{},
+	}
+}
+
+// Build constructs the EMF log entry as a JSON string.
+func (e *Entry) Build() (string, error) {
+
+	entry := map[string]interface{}{}
+
+	entry[emfIdentifier] = map[string]interface{}{
+		timestampKey: sdk.NowTime().UnixNano() / 1e6,
+		cloudWatchMetricsKey: []map[string]interface{}{
+			{
+				namespaceKey:  e.namespace,
+				dimensionsKey: e.dimensions,
+				metricsKey:    e.metrics,
+			},
+		},
+	}
+
+	for k, v := range e.fields {
+		entry[k] = v
+	}
+
+	jsonEntry, err := e.serializer.Serialize(entry)
+	if err != nil {
+		return "", err
+	}
+	return jsonEntry, nil
+}
+
+// AddDimension adds a CW Dimension to the EMF entry.
+func (e *Entry) AddDimension(key string, value string) {
+	// Dimensions are a list of lists. We only support a single list.
+	e.dimensions[0] = append(e.dimensions[0], key)
+	e.fields[key] = value
+}
+
+// AddMetric adds a CW Metric to the EMF entry.
+func (e *Entry) AddMetric(key string, value float64) {
+	e.metrics = append(e.metrics, metric{key})
+	e.fields[key] = value
+}
+
+// AddProperty adds a CW Property to the EMF entry.
+// Properties are not published as metrics, but they are available in logs and in CW insights.
+func (e *Entry) AddProperty(key string, value interface{}) {
+	e.fields[key] = value
+}
@@ -0,0 +1,145 @@
+// This package is designated as private and is intended for use only by the
+// smithy client runtime. The exported API therein is not considered stable and
+// is subject to breaking changes without notice.
+
+package emf
+
+import (
+	"fmt"
+	"reflect"
+	"testing"
+	"time"
+
+	"github.com/aws/aws-sdk-go-v2/aws/middleware/private/metrics"
+	"github.com/aws/aws-sdk-go-v2/internal/sdk"
+)
+
+type TestSerializerWithError struct{}
+
+func (TestSerializerWithError) Serialize(obj interface{}) (string, error) {
+	return "", fmt.Errorf("serialization error")
+}
+
+func TestCreateNewEntry(t *testing.T) {
+
+	sdk.NowTime = func() time.Time {
+		return time.Unix(1234, 0)
+	}
+
+	cases := map[string]struct {
+		Namespace     string
+		ExpectedEntry Entry
+	}{
+		"success": {
+			Namespace: "testNamespace",
+			ExpectedEntry: Entry{
+				namespace:  "testNamespace",
+				serializer: metrics.DefaultSerializer{},
+				metrics:    []metric{},
+				dimensions: [][]string{{}},
+				fields:     map[string]interface{}{},
+			},
+		},
+	}
+
+	for name, c := range cases {
+		t.Run(name, func(t *testing.T) {
+			actualEntry := NewEntry(c.Namespace, metrics.DefaultSerializer{})
+			if !reflect.DeepEqual(actualEntry, c.ExpectedEntry) {
+				t.Errorf("Entry contained unexpected values")
+			}
+		})
+	}
+}
+
+func TestBuild(t *testing.T) {
+
+	sdk.NowTime = func() time.Time {
+		return time.Unix(1234, 0)
+	}
+
+	cases := map[string]struct {
+		Namespace      string
+		Configure      func(entry *Entry)
+		Serializer     metrics.Serializer
+		ExpectedError  error
+		ExpectedResult string
+	}{
+		"completeEntry": {
+			Namespace:  "testNamespace",
+			Serializer: metrics.DefaultSerializer{},
+			Configure: func(entry *Entry) {
+				entry.AddMetric("testMetric1", 1)
+				entry.AddMetric("testMetric2", 2)
+				entry.AddDimension("testDimension1", "dim1")
+				entry.AddDimension("testDimension2", "dim2")
+				entry.AddProperty("testProperty1", "prop1")
+				entry.AddProperty("testProperty2", "prop2")
+			},
+			ExpectedError:  nil,
+			ExpectedResult: completeEntry,
+		},
+		"noMetrics": {
+			Namespace:  "testNamespace",
+			Serializer: metrics.DefaultSerializer{},
+			Configure: func(entry *Entry) {
+				entry.AddDimension("testDimension1", "dim1")
+				entry.AddDimension("testDimension2", "dim2")
+				entry.AddProperty("testProperty1", "prop1")
+				entry.AddProperty("testProperty2", "prop2")
+			},
+			ExpectedError:  nil,
+			ExpectedResult: noMetrics,
+		},
+		"noDimensions": {
+			Namespace:  "testNamespace",
+			Serializer: metrics.DefaultSerializer{},
+			Configure: func(entry *Entry) {
+				entry.AddMetric("testMetric1", 1)
+				entry.AddMetric("testMetric2", 2)
+				entry.AddProperty("testProperty1", "prop1")
+				entry.AddProperty("testProperty2", "prop2")
+			},
+			ExpectedError:  nil,
+			ExpectedResult: noDimensions,
+		},
+		"noProperties": {
+			Namespace:  "testNamespace",
+			Serializer: metrics.DefaultSerializer{},
+			Configure: func(entry *Entry) {
+				entry.AddMetric("testMetric1", 1)
+				entry.AddMetric("testMetric2", 2)
+				entry.AddDimension("testDimension1", "dim1")
+				entry.AddDimension("testDimension2", "dim2")
+			},
+			ExpectedError:  nil,
+			ExpectedResult: noProperties,
+		},
+		"serializationError": {
+			Namespace:  "testNamespace",
+			Serializer: TestSerializerWithError{},
+			Configure: func(entry *Entry) {
+			},
+			ExpectedError:  fmt.Errorf("serialization error"),
+			ExpectedResult: "",
+		},
+	}
+
+	for name, c := range cases {
+		t.Run(name, func(t *testing.T) {
+			entry := NewEntry(c.Namespace, c.Serializer)
+
+			c.Configure(&entry)
+
+			result, err := entry.Build()
+
+			if !reflect.DeepEqual(err, c.ExpectedError) {
+				t.Errorf("Unexpected error, should be '%s' but was '%s'", c.ExpectedError, err)
+			}
+
+			if !reflect.DeepEqual(result, c.ExpectedResult) {
+				t.Errorf("Unexpected result, should be '%s' but was '%s'", c.ExpectedResult, result)
+			}
+		})
+	}
+}