Fix notification and banner ETAs not in sync #1889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes notification and banner ETAs not in sync
Fixes #1887
Goal
This was a regression from #1412 where we updated the ETAs to consume NN ones but we forgot to change in
MapboxNavigationNotification. This PR solves thisImplementation
In
MapboxNavigationNotificationfix the duration remaining fromrouteProgress.durationRemaining()torouteProgress.currentLegProgress().durationRemaining()so both theSummaryModelandMapboxNavigationNotificationuse the same value. Took the opportunity to refactorMapboxNavigationNotificationand make it more testableScreenshots or Gifs
Before
After
Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed)Checklist