Add binary size metric and push to loading dock #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Guardiola31337
commented
Nov 26, 2018
Guardiola31337
commented
- Follow up work from [WIP] Add binary size metric and push to loading dock #1526
Codecov Report
@@ Coverage Diff @@
## master #1554 +/- ##
=========================================
Coverage 19.17% 19.17%
Complexity 684 684
=========================================
Files 184 184
Lines 9379 9379
Branches 608 608
=========================================
Hits 1798 1798
Misses 7398 7398
Partials 183 183 |
danesfeder
approved these changes
Nov 27, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Thanks for running with this @Guardiola31337 💯
This was referenced Nov 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.