From 9bea792f606ab0b87e8bfed0ba1652e78ddf9a2a Mon Sep 17 00:00:00 2001
From: Oleh Usik <o.usik@atwix.com>
Date: Sat, 7 Nov 2020 17:55:10 +0200
Subject: [PATCH] add Assert link action group

---
 .../ActionGroup/AssertLinkActionGroup.xml     | 22 +++++++
 .../Test/Mftf/Test/AdminPrivacyPolicyTest.xml | 59 +++++++++++++------
 2 files changed, 62 insertions(+), 19 deletions(-)
 create mode 100644 app/code/Magento/Backend/Test/Mftf/ActionGroup/AssertLinkActionGroup.xml

diff --git a/app/code/Magento/Backend/Test/Mftf/ActionGroup/AssertLinkActionGroup.xml b/app/code/Magento/Backend/Test/Mftf/ActionGroup/AssertLinkActionGroup.xml
new file mode 100644
index 0000000000000..6fa63d14b9612
--- /dev/null
+++ b/app/code/Magento/Backend/Test/Mftf/ActionGroup/AssertLinkActionGroup.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertLinkActionGroup">
+        <annotations>
+            <description>Assert text and url of the links.</description>
+        </annotations>
+        <arguments>
+            <argument name="text" type="string"/>
+            <argument name="url" type="string"/>
+        </arguments>
+
+        <seeLink userInput="{{text}}" url="{{url}}" stepKey="assertLinks"/>
+    </actionGroup>
+</actionGroups>
diff --git a/app/code/Magento/Backend/Test/Mftf/Test/AdminPrivacyPolicyTest.xml b/app/code/Magento/Backend/Test/Mftf/Test/AdminPrivacyPolicyTest.xml
index b0fbdb8b5b596..8b0bf1dc963ff 100644
--- a/app/code/Magento/Backend/Test/Mftf/Test/AdminPrivacyPolicyTest.xml
+++ b/app/code/Magento/Backend/Test/Mftf/Test/AdminPrivacyPolicyTest.xml
@@ -23,70 +23,91 @@
         <!-- Logging in Magento admin and checking for Privacy policy footer in dashboard -->
         <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
         <closeAdminNotification stepKey="closeAdminNotification"/>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkDashboard"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkDashboard">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in salesOrderPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToSalesOrder">
             <argument name="menuUiId" value="magento-sales-sales"/>
             <argument name="submenuUiId" value="magento-sales-sales-order"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkSalesOrder"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkSalesOrder">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in catalogProductsPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToCatalogProducts">
             <argument name="menuUiId" value="magento-catalog-catalog"/>
             <argument name="submenuUiId" value="magento-catalog-catalog-products"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkCatalogProducts"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkCatalogProducts">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in customersAllCustomersPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToCustomersAllCustomers">
             <argument name="menuUiId" value="magento-customer-customer"/>
             <argument name="submenuUiId" value="magento-customer-customer-manage"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkCustomersAllCustomers"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkCustomersAllCustomers">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in marketingCatalogPriceRulePage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToMarketingCatalogPriceRule">
             <argument name="menuUiId" value="magento-backend-marketing"/>
             <argument name="submenuUiId" value="magento-catalogrule-promo-catalog"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkMarketingCatalogPriceRule"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkMarketingCatalogPriceRule">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in contentBlocksPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToContentBlocks">
             <argument name="menuUiId" value="magento-backend-content"/>
             <argument name="submenuUiId" value="magento-cms-cms-block"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkContentBlocks"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkContentBlocks">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in reportSearcbTermsPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToReportsSearchTerms">
             <argument name="menuUiId" value="magento-reports-report"/>
             <argument name="submenuUiId" value="magento-search-report-search-term"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkReportsSearchTerms"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkReportsSearchTerms">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in storesAllStoresPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToStoresAllStores">
             <argument name="menuUiId" value="magento-backend-stores"/>
             <argument name="submenuUiId" value="magento-backend-system-store"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkStoresAllStores"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkStoresAllStores">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in systemImportPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToSystemImport">
             <argument name="menuUiId" value="magento-backend-system"/>
             <argument name="submenuUiId" value="magento-importexport-system-convert-import"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkSystemImport"/>
-
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkSystemImport">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
         <!-- Checking for Privacy policy footer in findPartnersAndExtensionsPage -->
         <actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToFindPartnersAndExtensions">
             <argument name="menuUiId" value="magento-marketplace-partners"/>
             <argument name="submenuUiId" value="magento-marketplace-partners"/>
         </actionGroup>
-        <seeLink userInput="Privacy Policy" url="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf" stepKey="seePrivacyPolicyLinkFindPartnersAndExtensions"/>
+        <actionGroup ref="AssertLinkActionGroup" stepKey="seePrivacyPolicyLinkFindPartnersAndExtensions">
+            <argument name="text" value="Privacy Policy"/>
+            <argument name="url" value="https://magento.com/sites/default/files/REVISED-MAGENTO-PRIVACY-POLICY.pdf"/>
+        </actionGroup>
     </test>
 </tests>