From 7341b4f3acb4fbca10b6b5dc76e560b8415e81d6 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 12 Aug 2020 13:08:38 +0500 Subject: [PATCH 1/4] System configuration Validation This field should be save empty, but incorrect validation was applied. Because of that, admin user couldn't save the empty value. --- app/code/Magento/Integration/etc/adminhtml/system.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Integration/etc/adminhtml/system.xml b/app/code/Magento/Integration/etc/adminhtml/system.xml index 6ef569a1d8a2f..2b15852563b20 100644 --- a/app/code/Magento/Integration/etc/adminhtml/system.xml +++ b/app/code/Magento/Integration/etc/adminhtml/system.xml @@ -16,7 +16,7 @@ We will disable this feature if the value is empty. - required-entry validate-zero-or-greater validate-number + validate-zero-or-greater validate-number From fdb4b7f5eba6441d453e26f41e36c0e1935bf865 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 19 Aug 2020 01:31:47 +0500 Subject: [PATCH 2/4] Incorrect required validation. Removed invalid "Required Validation" for both admin token and customer token. --- app/code/Magento/Integration/etc/adminhtml/system.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Integration/etc/adminhtml/system.xml b/app/code/Magento/Integration/etc/adminhtml/system.xml index 2b15852563b20..3d465a9642805 100644 --- a/app/code/Magento/Integration/etc/adminhtml/system.xml +++ b/app/code/Magento/Integration/etc/adminhtml/system.xml @@ -21,7 +21,7 @@ We will disable this feature if the value is empty. - required-entry validate-zero-or-greater validate-number + validate-zero-or-greater validate-number From 1f137fcb340fdba58cc85ab25a9100392e180c44 Mon Sep 17 00:00:00 2001 From: Alexander Steshuk Date: Fri, 21 Aug 2020 10:57:23 +0300 Subject: [PATCH 3/4] MFTF test. --- .../Page/AdminConfigServicesOauthPage.xml | 12 +++++++ ...dminConfigAccessTokenExpirationSection.xml | 17 +++++++++ .../Test/AdminConfigSaveEmptySettingsTest.xml | 35 +++++++++++++++++++ 3 files changed, 64 insertions(+) create mode 100644 app/code/Magento/Integration/Test/Mftf/Page/AdminConfigServicesOauthPage.xml create mode 100644 app/code/Magento/Integration/Test/Mftf/Section/AdminConfigAccessTokenExpirationSection.xml create mode 100644 app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml diff --git a/app/code/Magento/Integration/Test/Mftf/Page/AdminConfigServicesOauthPage.xml b/app/code/Magento/Integration/Test/Mftf/Page/AdminConfigServicesOauthPage.xml new file mode 100644 index 0000000000000..85f20c3617e1d --- /dev/null +++ b/app/code/Magento/Integration/Test/Mftf/Page/AdminConfigServicesOauthPage.xml @@ -0,0 +1,12 @@ + + + + +
+ + diff --git a/app/code/Magento/Integration/Test/Mftf/Section/AdminConfigAccessTokenExpirationSection.xml b/app/code/Magento/Integration/Test/Mftf/Section/AdminConfigAccessTokenExpirationSection.xml new file mode 100644 index 0000000000000..0f18c1e75979e --- /dev/null +++ b/app/code/Magento/Integration/Test/Mftf/Section/AdminConfigAccessTokenExpirationSection.xml @@ -0,0 +1,17 @@ + + + +
+ + + + + + +
+ diff --git a/app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml b/app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml new file mode 100644 index 0000000000000..ad1b27e7a0843 --- /dev/null +++ b/app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml @@ -0,0 +1,35 @@ + + + + + + + + + + <description value="Save settings 'Customer Token Lifetime' and 'Admin Token Lifetime' with empty values without validations."/> + <severity value="MINOR"/> + <group value="configuration"/> + </annotations> + <before> + <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/> + </before> + <after> + <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/> + </after> + <amOnPage url="{{AdminConfigServicesOauthPage.url}}" stepKey="navigateToConfigurationPage"/> + <waitForPageLoad stepKey="waitForPageLoad"/> + <conditionalClick selector="{{AdminConfigAccessTokenExpirationSection.tabAccessTokenLifetime}}" dependentSelector="{{AdminConfigAccessTokenExpirationSection.CheckIfTabExpand}}" visible="true" stepKey="expandTab"/> + <waitForAjaxLoad stepKey="waitForAjax"/> + <uncheckOption selector="{{AdminConfigAccessTokenExpirationSection.systemValueForTokenLifetime}}" stepKey="uncheckUseSystemValue"/> + <fillField selector="{{AdminConfigAccessTokenExpirationSection.valueForTokenLifetime}}" userInput="" stepKey="valueForTokenLifetime"/> + <uncheckOption selector="{{AdminConfigAccessTokenExpirationSection.systemValueForTokenLifetimeAdmin}}" stepKey="uncheckUseSystemValueAdmin"/> + <fillField selector="{{AdminConfigAccessTokenExpirationSection.valueForTokenLifetimeAdmin}}" userInput="" stepKey="valueForTokenLifetimeAdmin"/> + <actionGroup ref="AdminSaveConfigActionGroup" stepKey="saveConfig"/> + </test> +</tests> From 459fc2331762bdb7f5c9d84980d6980f712d5c99 Mon Sep 17 00:00:00 2001 From: "vadim.malesh" <engcom-vendorworker-charlie@adobe.com> Date: Fri, 4 Sep 2020 17:39:38 +0300 Subject: [PATCH 4/4] add testCaseId, change severity --- .../Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml b/app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml index ad1b27e7a0843..89a0fb4c1f026 100644 --- a/app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml +++ b/app/code/Magento/Integration/Test/Mftf/Test/AdminConfigSaveEmptySettingsTest.xml @@ -13,7 +13,8 @@ <stories value="Save settings 'Access Token Expiration'."/> <title value="Save settings 'Access Token Expiration' with empty values."/> <description value="Save settings 'Customer Token Lifetime' and 'Admin Token Lifetime' with empty values without validations."/> - <severity value="MINOR"/> + <severity value="AVERAGE"/> + <testCaseId value="MC-37382"/> <group value="configuration"/> </annotations> <before>