Skip to content

Conversation

@mahesh-rajawat
Copy link
Member

Fixed: Downloading a file from an order where the file type custom option is no longer present results in a 404.

Description (*)

Fixed Issues (if relevant)

  1. Uploaded file for custom option can't be downloaded again #20277
  2. ...

Manual testing scenarios (*)

  1. Create a product with a custom option of the type "File"
  2. Create a new order and upload a file for the product as a custom option
  3. Check the order and download the file, this is working.
  4. Update the product and delete the custom option from the product.
  5. Go back to the order and try to download the file again. No longer 404.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3887 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants