My-Accounttele-phone-field-require-no-validation-appear

[dipti2jcommerce]

In My Account dashboard page when we create new address from address book telephone field is require,but no validation appear while submission

Description (*)

In My Account dashboard page when we create new address from address book telephone field is require,but no validation appear while submission

Fixed Issues (if relevant)

In My Account dashboard page when we create new address from address book telephone field is require,but no validation appear while submission #20261

Manual testing scenarios (*)

Contribution checklist (*)

In My Account dashboard page when we create new address from address book telephone field is require,but no validation appear while submission

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @dipti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[tuyennn]

The problem came form the unknown
->getAttributeValidationClass('fax') which defined in telephone templates phtml, definitely this should be
->getAttributeValidationClass('telephone')

magento2/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml

Line 22 in 80d87ec

->getAttributeValidationClass('fax')

This happened only on branch 2.3

Please remove the lines, if this PR would be accepted

magento2/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml

Lines 19 to 24 in 80d87ec

	<?php
	$_validationClass = $block->escapeHtmlAttr(
	$this->helper('Magento\Customer\Helper\Address')
	->getAttributeValidationClass('fax')
	);
	?>

[dipti2jcommerce]

Hi @tuyennn ,
I have change value from fax to telephone ->getAttributeValidationClass('fax') which defined in telephone templates phtml, to
->getAttributeValidationClass('telephone').
And its working fine,please check.
Thanks,
Dipti

[tuyennn]

@dipti2jcommerce As I saw you made change to

class="input-text <?= $block->escapeHtmlAttr($block->getAttributeValidationClass('telephone')) ?>"

So why should we keep these lines? - You could remove those

magento2/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml

Lines 19 to 24 in 80d87ec

	<?php
	$_validationClass = $block->escapeHtmlAttr(
	$this->helper('Magento\Customer\Helper\Address')
	->getAttributeValidationClass('fax')
	);
	?>

[dipti2jcommerce]

Hi @tuyennn ,
I have removed my changes made previously and add changes as per requirement,please check .
Thanks,
Dipti

[magento-engcom-team]

@dipti2jcommerce thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[ghost]

Hi @dipti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @dipti2jcommerce. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.