From 26a07efbc3b4443b677b7280fb4a558637dc0130 Mon Sep 17 00:00:00 2001 From: "Leandro F. L" Date: Sat, 15 Dec 2018 23:44:10 -0200 Subject: [PATCH 1/7] Missing PHPDoc comment for method --- .../Model/ResourceModel/Stock/Item.php | 15 +++++++++++++++ .../Data/MySQLSearchDeprecationNotification.php | 4 ++++ .../Indexer/CustomerGroupDimensionProvider.php | 7 +++++++ .../Component/Form/Element/ActionDeleteTest.php | 3 +++ .../Component/Form/Element/CheckboxSetTest.php | 3 +++ .../Component/Form/Element/MultiSelectTest.php | 3 +++ .../Unit/Component/Form/Element/RadioSetTest.php | 3 +++ .../Unit/Component/Form/Element/SelectTest.php | 3 +++ .../Unit/Component/Form/Element/WysiwygTest.php | 3 +++ 9 files changed, 44 insertions(+) diff --git a/app/code/Magento/CatalogInventory/Model/ResourceModel/Stock/Item.php b/app/code/Magento/CatalogInventory/Model/ResourceModel/Stock/Item.php index ce8930ad4f7a6..2ba2bc26d53b0 100644 --- a/app/code/Magento/CatalogInventory/Model/ResourceModel/Stock/Item.php +++ b/app/code/Magento/CatalogInventory/Model/ResourceModel/Stock/Item.php @@ -263,6 +263,11 @@ public function updateLowStockDate(int $websiteId) $connection->update($this->getMainTable(), $value, $where); } + /** + * @param string $tableAlias + * + * @return \Zend_Db_Expr + */ public function getManageStockExpr(string $tableAlias = ''): \Zend_Db_Expr { if ($tableAlias) { @@ -277,6 +282,11 @@ public function getManageStockExpr(string $tableAlias = ''): \Zend_Db_Expr return $manageStock; } + /** + * @param string $tableAlias + * + * @return \Zend_Db_Expr + */ public function getBackordersExpr(string $tableAlias = ''): \Zend_Db_Expr { if ($tableAlias) { @@ -291,6 +301,11 @@ public function getBackordersExpr(string $tableAlias = ''): \Zend_Db_Expr return $itemBackorders; } + /** + * @param string $tableAlias + * + * @return \Zend_Db_Expr + */ public function getMinSaleQtyExpr(string $tableAlias = ''): \Zend_Db_Expr { if ($tableAlias) { diff --git a/app/code/Magento/CatalogSearch/Setup/Patch/Data/MySQLSearchDeprecationNotification.php b/app/code/Magento/CatalogSearch/Setup/Patch/Data/MySQLSearchDeprecationNotification.php index d3c5aa5aaa6f5..8fa9f56d78474 100644 --- a/app/code/Magento/CatalogSearch/Setup/Patch/Data/MySQLSearchDeprecationNotification.php +++ b/app/code/Magento/CatalogSearch/Setup/Patch/Data/MySQLSearchDeprecationNotification.php @@ -25,6 +25,10 @@ class MySQLSearchDeprecationNotification implements \Magento\Framework\Setup\Pat */ private $notifier; + /** + * @param \Magento\Framework\Search\EngineResolverInterface $searchEngineResolver + * @param \Magento\Framework\Notification\NotifierInterface $notifier + */ public function __construct( \Magento\Framework\Search\EngineResolverInterface $searchEngineResolver, \Magento\Framework\Notification\NotifierInterface $notifier diff --git a/app/code/Magento/Customer/Model/Indexer/CustomerGroupDimensionProvider.php b/app/code/Magento/Customer/Model/Indexer/CustomerGroupDimensionProvider.php index d4e0c5cce3401..0230832342b21 100644 --- a/app/code/Magento/Customer/Model/Indexer/CustomerGroupDimensionProvider.php +++ b/app/code/Magento/Customer/Model/Indexer/CustomerGroupDimensionProvider.php @@ -34,12 +34,19 @@ class CustomerGroupDimensionProvider implements DimensionProviderInterface */ private $dimensionFactory; + /** + * @param CustomerGroupCollectionFactory $collectionFactory + * @param DimensionFactory $dimensionFactory + */ public function __construct(CustomerGroupCollectionFactory $collectionFactory, DimensionFactory $dimensionFactory) { $this->dimensionFactory = $dimensionFactory; $this->collectionFactory = $collectionFactory; } + /** + * @inheritdoc + */ public function getIterator(): \Traversable { foreach ($this->getCustomerGroups() as $customerGroup) { diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php index 6f45c192d6c4c..a50e7b6aee42d 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php @@ -20,6 +20,9 @@ protected function getModelName() return ActionDelete::class; } + /** + * {@inheritdoc} + */ public function testGetComponentName() { $this->assertSame(ActionDelete::NAME, $this->getModel()->getComponentName()); diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php index 025f4a1582458..bef5c184ee38b 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php @@ -22,6 +22,9 @@ protected function getModelName() return CheckboxSet::class; } + /** + * {@inheritdoc} + */ public function testGetComponentName() { $this->assertSame(CheckboxSet::NAME, $this->getModel()->getComponentName()); diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php index cb91fbb945bb5..bc8eae46fd53f 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php @@ -22,6 +22,9 @@ protected function getModelName() return MultiSelect::class; } + /** + * {@inheritdoc} + */ public function testGetComponentName() { $this->contextMock->expects($this->never())->method('getProcessor'); diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php index 0e0fef60df60b..d0a252b6c68c7 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php @@ -22,6 +22,9 @@ protected function getModelName() return RadioSet::class; } + /** + * {@inheritdoc} + */ public function testGetComponentName() { $this->assertSame(RadioSet::NAME, $this->getModel()->getComponentName()); diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php index c695262681063..1ba5714f7ba3f 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php @@ -22,6 +22,9 @@ protected function getModelName() return Select::class; } + /** + * {@inheritdoc} + */ public function testGetComponentName() { $this->assertSame(Select::NAME, $this->getModel()->getComponentName()); diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php index b345989ba05ef..0bfa5a93d3640 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php @@ -92,6 +92,9 @@ protected function getModelName() return Wysiwyg::class; } + /** + * {@inheritdoc} + */ public function testGetComponentName() { $this->assertSame(Wysiwyg::NAME, $this->getModel()->getComponentName()); From 4e0435269dbe8589ad7cc871b831ce0b1268e828 Mon Sep 17 00:00:00 2001 From: Oleksii Korshenko Date: Wed, 23 Jan 2019 11:52:25 -0600 Subject: [PATCH 2/7] Update ActionDeleteTest.php Updated format to pass code style tests --- .../Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php index a50e7b6aee42d..2cb35c7b85ddc 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/ActionDeleteTest.php @@ -13,7 +13,7 @@ class ActionDeleteTest extends AbstractElementTest { /** - * {@inheritdoc} + * @inheritdoc */ protected function getModelName() { @@ -21,7 +21,7 @@ protected function getModelName() } /** - * {@inheritdoc} + * @inheritdoc */ public function testGetComponentName() { From 2f39cf0fcb1d2b54c1bab3d1f545cb1fcf727108 Mon Sep 17 00:00:00 2001 From: Oleksii Korshenko Date: Wed, 23 Jan 2019 11:52:46 -0600 Subject: [PATCH 3/7] Update CheckboxSetTest.php Updated format to pass code style tests --- .../Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php index bef5c184ee38b..3f00fa6c7ff34 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/CheckboxSetTest.php @@ -15,7 +15,7 @@ class CheckboxSetTest extends AbstractElementTest { /** - * {@inheritdoc} + * @inheritdoc */ protected function getModelName() { @@ -23,7 +23,7 @@ protected function getModelName() } /** - * {@inheritdoc} + * @inheritdoc */ public function testGetComponentName() { From 8f934c21dc1e57f14f166dcf28ba985fda94db26 Mon Sep 17 00:00:00 2001 From: Oleksii Korshenko Date: Wed, 23 Jan 2019 11:53:09 -0600 Subject: [PATCH 4/7] Update MultiSelectTest.php Updated format to pass code style tests --- .../Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php index bc8eae46fd53f..f37ca38a8d9bc 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/MultiSelectTest.php @@ -15,7 +15,7 @@ class MultiSelectTest extends AbstractElementTest { /** - * {@inheritdoc} + * @inheritdoc */ protected function getModelName() { @@ -23,7 +23,7 @@ protected function getModelName() } /** - * {@inheritdoc} + * @inheritdoc */ public function testGetComponentName() { From e381abfc2478183f2ce8ec13f263f66179b753e1 Mon Sep 17 00:00:00 2001 From: Oleksii Korshenko Date: Wed, 23 Jan 2019 11:53:31 -0600 Subject: [PATCH 5/7] Update RadioSetTest.php Updated format to pass code style tests --- .../Ui/Test/Unit/Component/Form/Element/RadioSetTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php index d0a252b6c68c7..67150e3c8fd3c 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/RadioSetTest.php @@ -15,7 +15,7 @@ class RadioSetTest extends AbstractElementTest { /** - * {@inheritdoc} + * @inheritdoc */ protected function getModelName() { @@ -23,7 +23,7 @@ protected function getModelName() } /** - * {@inheritdoc} + * @inheritdoc */ public function testGetComponentName() { From f6407d0f2ec011a2154cf4ec69b971c42f58d322 Mon Sep 17 00:00:00 2001 From: Oleksii Korshenko Date: Wed, 23 Jan 2019 11:55:19 -0600 Subject: [PATCH 6/7] Update SelectTest.php Updated format to pass code style tests --- .../Ui/Test/Unit/Component/Form/Element/SelectTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php index 1ba5714f7ba3f..d4677192cc084 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/SelectTest.php @@ -15,7 +15,7 @@ class SelectTest extends AbstractElementTest { /** - * {@inheritdoc} + * @inheritdoc */ protected function getModelName() { @@ -23,7 +23,7 @@ protected function getModelName() } /** - * {@inheritdoc} + * @inheritdoc */ public function testGetComponentName() { From bd60b6ba5925d6a452a02504c19b827e93088f90 Mon Sep 17 00:00:00 2001 From: Oleksii Korshenko Date: Wed, 23 Jan 2019 11:55:53 -0600 Subject: [PATCH 7/7] Update WysiwygTest.php Updated format to pass code style tests --- .../Ui/Test/Unit/Component/Form/Element/WysiwygTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php index 0bfa5a93d3640..4bfd952a6c566 100644 --- a/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php +++ b/app/code/Magento/Ui/Test/Unit/Component/Form/Element/WysiwygTest.php @@ -85,7 +85,7 @@ protected function getModel() } /** - * {@inheritdoc} + * @inheritdoc */ protected function getModelName() { @@ -93,7 +93,7 @@ protected function getModelName() } /** - * {@inheritdoc} + * @inheritdoc */ public function testGetComponentName() {