From ecca1f5f535d5dd2fa3b20734209b6194cb92468 Mon Sep 17 00:00:00 2001 From: Yaroslav Rogoza Date: Sun, 5 Aug 2018 19:05:16 +0200 Subject: [PATCH] Removed unnecessary unsets from models --- .../Magento/Braintree/Gateway/Http/Client/TransactionRefund.php | 2 -- .../Gateway/Http/Client/TransactionSubmitForSettlement.php | 2 -- .../Magento/Braintree/Gateway/Http/Client/TransactionVoid.php | 2 -- 3 files changed, 6 deletions(-) diff --git a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionRefund.php b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionRefund.php index 4c3f1e179d378..6d43929db7675 100644 --- a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionRefund.php +++ b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionRefund.php @@ -17,8 +17,6 @@ class TransactionRefund extends AbstractTransaction protected function process(array $data) { $storeId = $data['store_id'] ?? null; - // sending store id and other additional keys are restricted by Braintree API - unset($data['store_id']); return $this->adapterFactory->create($storeId) ->refund($data['transaction_id'], $data[PaymentDataBuilder::AMOUNT]); diff --git a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionSubmitForSettlement.php b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionSubmitForSettlement.php index 16ebd7a7a00c5..6760e724fd3a6 100644 --- a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionSubmitForSettlement.php +++ b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionSubmitForSettlement.php @@ -19,8 +19,6 @@ class TransactionSubmitForSettlement extends AbstractTransaction protected function process(array $data) { $storeId = $data['store_id'] ?? null; - // sending store id and other additional keys are restricted by Braintree API - unset($data['store_id']); return $this->adapterFactory->create($storeId) ->submitForSettlement($data[CaptureDataBuilder::TRANSACTION_ID], $data[PaymentDataBuilder::AMOUNT]); diff --git a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionVoid.php b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionVoid.php index e9a478a8bac23..0a940839fc154 100644 --- a/app/code/Magento/Braintree/Gateway/Http/Client/TransactionVoid.php +++ b/app/code/Magento/Braintree/Gateway/Http/Client/TransactionVoid.php @@ -15,8 +15,6 @@ class TransactionVoid extends AbstractTransaction protected function process(array $data) { $storeId = $data['store_id'] ?? null; - // sending store id and other additional keys are restricted by Braintree API - unset($data['store_id']); return $this->adapterFactory->create($storeId)->void($data['transaction_id']); }