From 5e7ed2b231f6f276d2b871e72bf57ec7a8a4c389 Mon Sep 17 00:00:00 2001
From: Cristian Sanclemente <cristian.sanclemente@interactiv4.com>
Date: Sun, 5 Nov 2017 21:59:47 +0100
Subject: [PATCH] Create cancel method on API

---
 .../Sales/Api/InvoiceCancelInterface.php      | 23 ++++++++
 .../Sales/Model/Order/InvoiceCancel.php       | 50 ++++++++++++++++
 .../Unit/Model/Service/InvoiceServiceTest.php | 58 +++++++++++++++++++
 app/code/Magento/Sales/etc/di.xml             |  3 +-
 app/code/Magento/Sales/etc/webapi.xml         |  8 ++-
 5 files changed, 140 insertions(+), 2 deletions(-)
 create mode 100644 app/code/Magento/Sales/Api/InvoiceCancelInterface.php
 create mode 100644 app/code/Magento/Sales/Model/Order/InvoiceCancel.php

diff --git a/app/code/Magento/Sales/Api/InvoiceCancelInterface.php b/app/code/Magento/Sales/Api/InvoiceCancelInterface.php
new file mode 100644
index 0000000000000..56694f20b261f
--- /dev/null
+++ b/app/code/Magento/Sales/Api/InvoiceCancelInterface.php
@@ -0,0 +1,23 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Sales\Api;
+
+/**
+ * Interface InvoiceCancelInterface
+ *
+ * @package Magento\Sales\Api
+ */
+interface InvoiceCancelInterface
+{
+
+    /**
+     * Cancel invoice
+     *
+     * @param int $invoiceId
+     * @return bool
+     */
+    public function cancel($invoiceId);
+}
diff --git a/app/code/Magento/Sales/Model/Order/InvoiceCancel.php b/app/code/Magento/Sales/Model/Order/InvoiceCancel.php
new file mode 100644
index 0000000000000..035801f772ba2
--- /dev/null
+++ b/app/code/Magento/Sales/Model/Order/InvoiceCancel.php
@@ -0,0 +1,50 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Sales\Model\Order;
+
+use Magento\Sales\Api\InvoiceCancelInterface;
+use Magento\Sales\Api\InvoiceRepositoryInterface;
+
+/**
+ * Class InvoiceCancel
+ */
+class InvoiceCancel implements InvoiceCancelInterface
+{
+
+    /**
+     * @var InvoiceRepositoryInterface
+     */
+    protected $invoiceRepository;
+
+    /**
+     * InvoiceCancel constructor.
+     * @param InvoiceRepositoryInterface $invoiceRepository
+     */
+    public function __construct(
+        InvoiceRepositoryInterface $invoiceRepository
+    ) {
+        $this->invoiceRepository = $invoiceRepository;
+    }
+
+    /**
+     * Cancel invoice
+     *
+     * @param int $invoiceId
+     * @return bool
+     */
+    public function cancel($invoiceId)
+    {
+        /** @var \Magento\Sales\Api\Data\InvoiceInterface $invoice */
+        $invoice = $this->invoiceRepository->get($invoiceId);
+        if ($invoice && $invoice->canCancel()) {
+            $invoice->cancel();
+            $this->invoiceRepository->save($invoice);
+            return true;
+        }
+
+        return false;
+    }
+}
diff --git a/app/code/Magento/Sales/Test/Unit/Model/Service/InvoiceServiceTest.php b/app/code/Magento/Sales/Test/Unit/Model/Service/InvoiceServiceTest.php
index 30d26de5a06b1..b3aa4f1283aff 100644
--- a/app/code/Magento/Sales/Test/Unit/Model/Service/InvoiceServiceTest.php
+++ b/app/code/Magento/Sales/Test/Unit/Model/Service/InvoiceServiceTest.php
@@ -19,6 +19,13 @@ class InvoiceServiceTest extends \PHPUnit\Framework\TestCase
      */
     protected $repositoryMock;
 
+    /**
+     * Invoice Cancel
+     *
+     * @var \Magento\Sales\Api\InvoiceCancelInterface|\PHPUnit_Framework_MockObject_MockObject
+     */
+    protected $invoiceCancelMock;
+
     /**
      * Repository
      *
@@ -52,6 +59,11 @@ class InvoiceServiceTest extends \PHPUnit\Framework\TestCase
      */
     protected $invoiceService;
 
+    /**
+     * @var \Magento\Sales\Model\Order\Invoice
+     */
+    protected $invoiceMock;
+
     /**
      * SetUp
      */
@@ -84,6 +96,16 @@ protected function setUp()
             ['notify']
         );
 
+        $this->invoiceCancelMock = new \Magento\Sales\Model\Order\InvoiceCancel(
+            $this->repositoryMock
+        );
+
+        $this->invoiceMock = $this->getMockBuilder(
+            \Magento\Sales\Model\Order\Invoice::class
+        )
+            ->disableOriginalConstructor()
+            ->getMock();
+
         $this->invoiceService = $objectManager->getObject(
             \Magento\Sales\Model\Service\InvoiceService::class,
             [
@@ -204,4 +226,40 @@ public function testSetVoid()
 
         $this->assertTrue($this->invoiceService->setVoid($id));
     }
+
+    /**
+     * Run test for Invoice::cancel()
+     */
+    public function testCancel()
+    {
+        $this->repositoryMock->expects($this->once())
+            ->method('get')
+            ->with(123)
+            ->willReturn($this->invoiceMock);
+        $this->invoiceMock->expects($this->once())
+            ->method('cancel')
+            ->willReturn($this->invoiceMock);
+        $this->invoiceMock->expects($this->once())
+            ->method('canCancel')
+            ->willReturn(true);
+        $this->assertTrue($this->invoiceCancelMock->cancel(123));
+    }
+
+    /**
+     * test for Invoice::cancel() fail case
+     */
+    public function testCancelFailed()
+    {
+        $this->repositoryMock->expects($this->once())
+            ->method('get')
+            ->with(123)
+            ->willReturn($this->invoiceMock);
+        $this->invoiceMock->expects($this->never())
+            ->method('cancel')
+            ->willReturn($this->invoiceMock);
+        $this->invoiceMock->expects($this->once())
+            ->method('canCancel')
+            ->willReturn(false);
+        $this->assertFalse($this->invoiceCancelMock->cancel(123));
+    }
 }
diff --git a/app/code/Magento/Sales/etc/di.xml b/app/code/Magento/Sales/etc/di.xml
index 9de3f238d6a39..5001e85856757 100644
--- a/app/code/Magento/Sales/etc/di.xml
+++ b/app/code/Magento/Sales/etc/di.xml
@@ -56,6 +56,7 @@
     <preference for="Magento\Sales\Api\Data\InvoiceCreationArgumentsInterface" type="Magento\Sales\Model\Order\Invoice\CreationArguments"/>
     <preference for="Magento\Sales\Api\Data\InvoiceItemCreationInterface" type="Magento\Sales\Model\Order\Invoice\ItemCreation"/>
     <preference for="Magento\Sales\Api\Data\InvoiceCommentCreationInterface" type="Magento\Sales\Model\Order\Invoice\CommentCreation"/>
+    <preference for="Magento\Sales\Api\InvoiceCancelInterface" type="Magento\Sales\Model\Order\InvoiceCancel"/>
     <preference for="Magento\Sales\Api\Data\ShipmentCommentCreationInterface" type="Magento\Sales\Model\Order\Shipment\CommentCreation"/>
     <preference for="Magento\Sales\Api\Data\CreditmemoCommentCreationInterface" type="Magento\Sales\Model\Order\Creditmemo\CommentCreation"/>
     <preference for="Magento\Sales\Api\OrderAddressRepositoryInterface" type="Magento\Sales\Model\Order\AddressRepository"/>
@@ -982,4 +983,4 @@
             </argument>
         </arguments>
     </type>
-</config>
+</config>
\ No newline at end of file
diff --git a/app/code/Magento/Sales/etc/webapi.xml b/app/code/Magento/Sales/etc/webapi.xml
index cee245e348393..cbb59f29c0645 100644
--- a/app/code/Magento/Sales/etc/webapi.xml
+++ b/app/code/Magento/Sales/etc/webapi.xml
@@ -139,6 +139,12 @@
             <resource ref="Magento_Sales::sales" />
         </resources>
     </route>
+    <route url="/V1/invoice/:invoiceId/cancel" method="POST">
+        <service class="Magento\Sales\Api\InvoiceCancelInterface" method="cancel"/>
+        <resources>
+            <resource ref="Magento_Sales::sales" />
+        </resources>
+    </route>
     <route url="/V1/creditmemo/:id/comments" method="GET">
         <service class="Magento\Sales\Api\CreditmemoManagementInterface" method="getCommentsList"/>
         <resources>
@@ -277,4 +283,4 @@
             <resource ref="Magento_Sales::sales" />
         </resources>
     </route>
-</routes>
+</routes>
\ No newline at end of file