Skip to content

[Issue] Move default session lifetime from encryption module to security module #30859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m2-assistant bot opened this issue Nov 9, 2020 · 2 comments · Fixed by #30825
Closed

[Issue] Move default session lifetime from encryption module to security module #30859

m2-assistant bot opened this issue Nov 9, 2020 · 2 comments · Fixed by #30825
Assignees
@thomas-kl1
Labels
Component: EncryptionKey Component: Security Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 9, 2020 •
edited by engcom-Alfa
Loading

Preconditions:

This issue is automatically created based on existing pull request: #30825: Move default session lifetime from encryption module to security module

Steps to reproduce:

  1. Go to Admin -> Stores -> Configuration -> Advanced -> Admin -> Security and set
    Admin Session Lifetime (seconds) to 60 sec;

Screenshot from 2020-11-10 14-56-14
2. Save settings and clear cache;
3. Wait 60 sec and click on the Dashboard;

Expected Result: ✔️ The user admin has been logged out

Screenshot from 2020-11-10 14-58-32

Move default session lifetime from encryption module to security module
@m2-assistant m2-assistant bot added Component: EncryptionKey Component: Security Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Nov 9, 2020
@m2-assistant m2-assistant bot mentioned this issue Nov 9, 2020
Merged
1 task
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 10, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-38996 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30825 by @thomas-kl1 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 15, 2020
@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in Low Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas-kl1 thomas-kl1

Labels
Component: EncryptionKey Component: Security Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move default session lifetime from encryption module to security module thomas-kl1/magento2
3 participants
@thomas-kl1 @magento-engcom-team @engcom-Alfa